Issue 10986008: Switch to using WebKit's test expecation parser.

Issue 10986008: Switch to using WebKit's test expecation parser. (Closed)

Created:
8 years, 3 months ago by DaleCurtis

Modified:
8 years, 2 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch to using WebKit's test expecation parser. Switches the TestExpecations file parser from our hand rolled parsing code over to using WebKit's parsing libraries directly. Fixes LayoutTestAnalyzer to work with the new TestExpecations file format. Requires WebKit/Tools/Scripts/ in PYTHONPATH. BUG=none TEST=unit tests, local runs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158848

Patch Set 1 : Comments. #

Total comments: 6

Patch Set 2 : Comments. #

Patch Set 3 : Bug fixes. #

Patch Set 4 : Use no-reply. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -154 lines)			Patch
M	media/tools/layout_tests/layouttest_analyzer_helpers.py	View	1 2 3	4 chunks	+7 lines, -9 lines	0 comments	Download
M	media/tools/layout_tests/test_expectations.py	View		4 chunks	+70 lines, -108 lines	0 comments	Download
M	media/tools/layout_tests/test_expectations_unittest.py	View		1 chunk	+17 lines, -37 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

LGTM https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layouttest_analyzer_helpers.py File media/tools/layout_tests/layouttest_analyzer_helpers.py (right): https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layouttest_analyzer_helpers.py#newcode56 media/tools/layout_tests/layouttest_analyzer_helpers.py:56: refer to |test_expectaions.ALL_TE_KEYWORDS|). test_expectaions typo https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layouttest_analyzer_helpers.py#newcode67 media/tools/layout_tests/layouttest_analyzer_helpers.py:67: if ...

8 years, 3 months ago (2012-09-25 00:40:30 UTC) #2

DaleCurtis

8 years, 3 months ago (2012-09-25 01:14:50 UTC) #3

Will do some prod-side testing tomorrow. My ssh access to the cluster seems to
have died :(

https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layo...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layo...
media/tools/layout_tests/layouttest_analyzer_helpers.py:56: refer to
|test_expectaions.ALL_TE_KEYWORDS|).
On 2012/09/25 00:40:30, Ami Fischman wrote:
> test_expectaions typo

Done.

https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layo...
media/tools/layout_tests/layouttest_analyzer_helpers.py:67: if any([True for x
in value['te_info'] if set(x.keys()) ==
On 2012/09/25 00:40:30, Ami Fischman wrote:
> I'm confused by the == (I'd expect a "containedIn" or somesuch).

Doing a subset would match SLOW PASS IMAGE.

https://codereview.chromium.org/10986008/diff/4/media/tools/layout_tests/layo...
media/tools/layout_tests/layouttest_analyzer_helpers.py:68: set(['SLOW', 'PASS',
'Bugs', 'Comments', 'Platforms']) or
On 2012/09/25 00:40:30, Ami Fischman wrote:
> indent is off?

Done.

Expand Messages | Collapse Messages