Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: media/tools/layout_tests/layouttest_analyzer_helpers.py

Issue 10986008: Switch to using WebKit's test expecation parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use no-reply. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/tools/layout_tests/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/tools/layout_tests/layouttest_analyzer_helpers.py
diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers.py b/media/tools/layout_tests/layouttest_analyzer_helpers.py
index b64c25701d0994c46b082d6b6cdfad06a1930353..cbcf79cce5d0817aeb65a65e645aad3f3de093a7 100644
--- a/media/tools/layout_tests/layouttest_analyzer_helpers.py
+++ b/media/tools/layout_tests/layouttest_analyzer_helpers.py
@@ -53,7 +53,7 @@ class AnalyzerResultMap:
which is a list of test expectation information map. The key of the
test expectation information map is test expectation keywords such
as "SKIP" and other keywords (for full list of keywords, please
- refer to |test_expectaions.ALL_TE_KEYWORDS|).
+ refer to |test_expectations.ALL_TE_KEYWORDS|).
"""
self.result_map = {}
self.result_map['whole'] = {}
@@ -63,12 +63,10 @@ class AnalyzerResultMap:
for (k, value) in test_info_map.iteritems():
self.result_map['whole'][k] = value
if 'te_info' in value:
- # Don't count SLOW PASS or WONTFIX tests as failures.
+ # Don't count SLOW PASS, WONTFIX, or ANDROID tests as failures.
if any([True for x in value['te_info'] if set(x.keys()) ==
- set(['SLOW', 'PASS', 'Bugs', 'Comments']) or 'WONTFIX' in x]):
- continue
- # Ignore failures on the ANDROID platform.
- if value['te_info']['Platforms'] == ['ANDROID']:
+ set(['SLOW', 'PASS', 'Bugs', 'Comments', 'Platforms']) or
+ 'WONTFIX' in x or x['Platforms'] == ['ANDROID']]):
continue
if any([True for x in value['te_info'] if 'SKIP' in x]):
self.result_map['skip'][k] = value
@@ -243,7 +241,8 @@ class AnalyzerResultMap:
'flakiness_dashboard.html#%stests=%s') % (
gpu_link, test_name)
return_str += '<li><a href="%s">%s</a> (%s) </li>' % (
- dashboard_link, test_name, ' '.join(te_info.keys()))
+ dashboard_link, test_name, ' '.join(
+ [key for key in te_info.keys() if key != 'Platforms']))
return_str += '</ul>\n'
return return_str
@@ -370,8 +369,7 @@ def SendStatusEmail(prev_time, analyzer_result_map, diff_map,
subject = 'Layout Test Analyzer Result %s(%s): %s' % (change_str,
test_group_name,
localtime)
- # TODO(imasaki): remove my name from here.
- SendEmail('imasaki@chromium.org', [receiver_email_address],
+ SendEmail('no-reply@chromium.org', [receiver_email_address],
subject, email_content + appended_text_to_email)
« no previous file with comments | « no previous file | media/tools/layout_tests/test_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698