Issue 1098503002: Remove the is_ensemble build variable from the GN files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1098503002: Remove the is_ensemble build variable from the GN files. (Closed)

Created:
5 years, 8 months ago by wtc

Modified:
5 years, 8 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove the is_ensemble build variable from the GN files. This reverts https://codereview.chromium.org/914363002 completely. Some of the changes have already been reverted in https://codereview.chromium.org/1008683002. R=dalecurtis@chromium.org BUG=457280 Committed: https://crrev.com/44f9d6b9414561b7167213128d06c977c256f781 Cr-Commit-Position: refs/heads/master@{#325517}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -30 lines)			Patch
M	media/BUILD.gn	View	4 chunks	+12 lines, -21 lines	0 comments	Download
M	media/base/BUILD.gn	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	media/media_options.gni	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098503002/1

5 years, 8 months ago (2015-04-16 21:26:23 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 21:38:47 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/44f9d6b9414561b7167213128d06c977c256f781
Cr-Commit-Position: refs/heads/master@{#325517}