Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 1008683002: Allow a dependency on skia when is_ensemble is true. (Closed)

Created:
5 years, 9 months ago by wtc
Modified:
5 years, 9 months ago
Reviewers:
xhwang, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow a dependency on skia when is_ensemble is true. Originally I avoided the dependency on the X11 and Linux fontconfig libraries by avoiding skia. I found that Blink and ui/gfx use skia heavily, so I need a different solution to avoid X11 and fontconfig. I am adjusting my previous solution slightly so that Blink can be built. R=dalecurtis@chromium.org,xhwang@chromium.org BUG=457280 Committed: https://crrev.com/5a31fbc6196314347c5787e58428c2484d491eb0 Cr-Commit-Position: refs/heads/master@{#320526}

Patch Set 1 #

Patch Set 2 : Update the comment for the is_ensemble build variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M media/BUILD.gn View 5 chunks +8 lines, -13 lines 0 comments Download
M media/media_options.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
wtc
5 years, 9 months ago (2015-03-13 02:20:08 UTC) #1
wtc
Hi Xiaohan, Dale is the best person to review this CL because he reviewed the ...
5 years, 9 months ago (2015-03-13 02:24:13 UTC) #3
xhwang
lgtm
5 years, 9 months ago (2015-03-13 03:34:01 UTC) #4
wtc
Xiaohan: thanks for the review. I just realized that I also needed to update the ...
5 years, 9 months ago (2015-03-13 17:35:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008683002/20001
5 years, 9 months ago (2015-03-13 17:36:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-13 17:56:05 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 17:56:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a31fbc6196314347c5787e58428c2484d491eb0
Cr-Commit-Position: refs/heads/master@{#320526}

Powered by Google App Engine
This is Rietveld 408576698