Issue 10984012: Add support for extra_gyp_defines in factory props

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984012: Add support for extra_gyp_defines in factory props (Closed)

Created:
8 years, 3 months ago by Isaac (away)

Modified:
8 years, 3 months ago

Reviewers:
Yaron

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add support for extra_gyp_defines in factory props - Will be used for clang builder, and possibly other bot customizations. R=yfriedman@chromium.org BUG=143931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158474

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	build/android/buildbot/buildbot_functions.sh	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Isaac (away)

8 years, 3 months ago (2012-09-25 00:58:29 UTC) #3

Isaac's CQ is trying da patch

$ git cl dcommit
Cannot dcommit with a dirty tree.
$ sudo git cl dcommit
Done