Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3639)

Unified Diff: build/android/buildbot/buildbot_functions.sh

Issue 10984012: Add support for extra_gyp_defines in factory props (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/buildbot_functions.sh
diff --git a/build/android/buildbot/buildbot_functions.sh b/build/android/buildbot/buildbot_functions.sh
index 482ec9030934ed10b979da0f845c530d2d3df7a3..92d989ac135d6cb7d815ab0b47aad771f5a36a66 100755
--- a/build/android/buildbot/buildbot_functions.sh
+++ b/build/android/buildbot/buildbot_functions.sh
@@ -83,7 +83,8 @@ function bb_baseline_setup {
bb_setup_goma_internal
. build/android/envsetup.sh
export GYP_DEFINES+=" fastbuild=1"
-
+ export GYP_DEFINES+=" $(bb_get_json_prop "$FACTORY_PROPERTIES" \
+ extra_gyp_defines)"
# Should be called only after envsetup is done.
bb_run_gclient_hooks
}
@@ -311,5 +312,5 @@ function bb_get_json_prop {
local JSON="$1"
local PROP="$2"
- python -c "import json; print json.loads('$JSON').get('$PROP')"
+ python -c "import json; print json.loads('$JSON').get('$PROP', '')"
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698