Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 109823012: Pass ctm when performing image filtering in GPU backend. (Closed)

Created:
6 years, 11 months ago by bsalomon
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Rename GPU functions on SkBlurMaskFilter and pass ctm. Committed: http://code.google.com/p/skia/source/detail?r=12978

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : remove bmp version of filter func #

Total comments: 8

Patch Set 4 : Rob's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -83 lines) Patch
M include/core/SkMaskFilter.h View 1 2 3 2 chunks +26 lines, -30 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 2 2 chunks +2 lines, -51 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
After much noodling around with the function names and signatures I wound up not too ...
6 years, 11 months ago (2014-01-08 19:43:59 UTC) #1
robertphillips
lgtm + nits & a question https://codereview.chromium.org/109823012/diff/40001/include/core/SkMaskFilter.h File include/core/SkMaskFilter.h (right): https://codereview.chromium.org/109823012/diff/40001/include/core/SkMaskFilter.h#newcode66 include/core/SkMaskFilter.h:66: * Returns true ...
6 years, 11 months ago (2014-01-08 20:15:18 UTC) #2
bsalomon
https://codereview.chromium.org/109823012/diff/40001/include/core/SkMaskFilter.h File include/core/SkMaskFilter.h (right): https://codereview.chromium.org/109823012/diff/40001/include/core/SkMaskFilter.h#newcode66 include/core/SkMaskFilter.h:66: * Returns true if the filter can be expressed ...
6 years, 11 months ago (2014-01-08 21:38:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/109823012/110001
6 years, 11 months ago (2014-01-08 21:38:55 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 22:25:56 UTC) #5
Message was sent while issue was closed.
Change committed as 12978

Powered by Google App Engine
This is Rietveld 408576698