Issue 109823011: Revert "Don't set document.title when there is no <head>"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109823011: Revert "Don't set document.title when there is no <head>" (Closed)

Created:
6 years, 11 months ago by adamk

Modified:
6 years, 11 months ago

Reviewers:
wjmaclean

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive, davve, jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Revert "Don't set document.title when there is no <head>" This reverts https://src.chromium.org/viewvc/blink?revision=164582&view=revision It caused Chromium browser_test ClickToPlayPluginTest.NoCallbackAtLoad to fail, as that test expects to be able to set document.title to "OK" read it back, in a document that apparently has no <head>. TBR=wjmaclean@chromium.org BUG=330165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164623

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -32 lines)			Patch
D	LayoutTests/fast/dom/document-set-title-no-head.html	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	LayoutTests/fast/dom/document-set-title-no-head-expected.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

adamk

6 years, 11 months ago (2014-01-07 22:36:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r164623 (presubmit successful).