Source/core/dom/Document.cpp - Issue 109823011: Revert "Don't set document.title when there is no <head>"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 109823011: Revert "Don't set document.title when there is no <head>" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index f21b660e3910c6a142019bc285a0299d8a1999bc..7d7e94c4a5260e4aa94755f74f1f30f178403210 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -1294,21 +1294,18 @@ void Document::updateTitle(const String& title)

m_frame->loader().client()->dispatchDidReceiveTitle(m_title);

}

-// http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#document.title

void Document::setTitle(const String& title)

{

+ // Title set by JavaScript -- overrides any title elements.

+ m_titleSetExplicitly = true;

if (!isHTMLDocument() && !isXHTMLDocument())

m_titleElement = 0;

else if (!m_titleElement) {

if (HTMLElement* headElement = head()) {

m_titleElement = createElement(titleTag, false);

headElement->appendChild(m_titleElement);

- } else {

- // "If the title element is null and the head element is null, then the attribute must do nothing."

- return;

}

- m_titleSetExplicitly = true;

if (m_titleElement)

m_titleElement->removeChildren();

« no previous file with comments | « LayoutTests/fast/dom/document-set-title-no-head-expected.txt ('k') | no next file » | no next file with comments »