include/core/SkPicture.h - Issue 1098183003: Reduce ref counting in SkPictureRecorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPicture.h

Issue 1098183003: Reduce ref counting in SkPictureRecorder. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkPicture.h

diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h

index fba0a3593979e20e5278c3928b8ca2c5c0933eac..6445986612b3b9b25c120d50ab46e2e2a1582730 100644

--- a/include/core/SkPicture.h

+++ b/include/core/SkPicture.h

@@ -259,7 +259,8 @@ private:

void createHeader(SkPictInfo* info) const;

static bool IsValidPictInfo(const SkPictInfo& info);

- // Takes ownership of the SkRecord and (optional) SnapshotArray, refs the (optional) BBH.

+ // Takes ownership of the (optional) SnapshotArray.

+ // For performance, we take ownership of the caller's refs on the SkRecord and BBH.

SkPicture(const SkRect& cullRect,

SkRecord*,

SnapshotArray*,

« no previous file with comments | « no previous file | src/core/SkPicture.cpp » ('j') | no next file with comments »