src/core/SkPicture.cpp - Issue 1098183003: Reduce ref counting in SkPictureRecorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicture.cpp

Issue 1098183003: Reduce ref counting in SkPictureRecorder. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPicture.cpp

diff --git a/src/core/SkPicture.cpp b/src/core/SkPicture.cpp

index 4d4364aec6988d641b17c9d714d7ad65d35e4228..619be8b3ca1a9a8572494a496e74fd3e1eac8e99 100644

--- a/src/core/SkPicture.cpp

+++ b/src/core/SkPicture.cpp

@@ -456,8 +456,8 @@ SkPicture::SkPicture(const SkRect& cullRect, SkRecord* record, SnapshotArray* dr

SkBBoxHierarchy* bbh, size_t approxBytesUsedBySubPictures)

: fUniqueID(0)

, fCullRect(cullRect)

- , fRecord(SkRef(record))

- , fBBH(SkSafeRef(bbh))

+ , fRecord(record) // For performance, we take ownership of the caller's ref.

+ , fBBH(bbh) // Ditto.

, fDrawablePicts(drawablePicts) // take ownership

, fApproxBytesUsedBySubPictures(approxBytesUsedBySubPictures)

, fAnalysis(*fRecord)

« no previous file with comments | « include/core/SkPicture.h ('k') | src/core/SkPictureRecorder.cpp » ('j') | no next file with comments »