Reduce ref counting in SkPictureRecorder.

Reduce ref counting in SkPictureRecorder.

This may be a small help to slimming paint:

  picture_overhead_draw 1.25us -> 1.22us    0.98x
  picture_overhead_nodraw    318ns ->  276ns    0.87x

It certainly cannot hurt performance.

BUG=chromium:470553
TBR=reed@google.com
No public API changes.

Committed: https://skia.googlesource.com/skia/+/00c2af8b731085a7fe456e689b70f019a34ef7dd

[mtklein_C, 2015-04-21 21:59:41]

mtklein@chromium.org changed reviewers:
+ reed@google.com, robertphillips@google.com

[mtklein_C, 2015-04-21 21:59:42]

First reviewer wins.

[mtklein, 2015-04-21 22:00:42]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 22:00:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1098183003/1

[commit-bot: I haz the power, 2015-04-21 22:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 22:06:13]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-04-24 12:42:08]

lgtm

[mtklein, 2015-04-24 14:55:26]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-04-24 14:55:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1098183003/1

[commit-bot: I haz the power, 2015-04-24 14:55:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 14:55:44]

Failed to apply patch for include/core/SkPicture.h:
While running git apply --index -3 -p1;
  error: patch failed: include/core/SkPicture.h:259
  Falling back to three-way merge...
  Applied patch to 'include/core/SkPicture.h' with conflicts.
  U include/core/SkPicture.h

Patch:       include/core/SkPicture.h
Index: include/core/SkPicture.h
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index
8a6216e1aa14092a9ed12b1b9c0c095bb01b2a89..f53a631597ea72830e2d7bd5325d2a9215450e4f
100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -259,7 +259,8 @@ private:
     void createHeader(SkPictInfo* info) const;
     static bool IsValidPictInfo(const SkPictInfo& info);
 
-    // Takes ownership of the SkRecord and (optional) SnapshotArray, refs the
(optional) BBH.
+    // Takes ownership of the (optional) SnapshotArray.
+    // For performance, we take ownership of the caller's refs on the SkRecord
and BBH.
     SkPicture(const SkRect& cullRect, SkRecord*, SnapshotArray*,
SkBBoxHierarchy*);
 
     static SkPicture* Forwardport(const SkPictInfo&, const SkPictureData*);

[mtklein, 2015-04-27 15:45:46]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-04-27 15:45:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1098183003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-27 15:45:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1098183003/20001

[commit-bot: I haz the power, 2015-04-27 15:54:26]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/00c2af8b731085a7fe456e689b70f019a34ef7dd