Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 109813002: Remove dbus_unittests from linux testers. (Closed)

Created:
7 years ago by Nico
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove dbus_unittests from linux testers. https://codereview.chromium.org/107313002 attempted to do this, but only removed it from the builder, not from the tester, leading to the testers testing stale binaries, which eventually caused them to die at startup due to unresolved symbols. Another victim of test name remapping in ChromiumFactory. BUG=326272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/masters/master.chromium.linux/master_linux_cfg.py View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
7 years ago (2013-12-08 22:00:14 UTC) #1
Nico
(cc'ing maruel in case he's around)
7 years ago (2013-12-08 22:30:36 UTC) #2
hashimoto
On 2013/12/08 22:30:36, Nico wrote: > (cc'ing maruel in case he's around) Could you hold ...
7 years ago (2013-12-09 06:40:23 UTC) #3
agable
On 2013/12/09 06:40:23, hashimoto wrote: > On 2013/12/08 22:30:36, Nico wrote: > > (cc'ing maruel ...
7 years ago (2013-12-09 22:12:41 UTC) #4
Elliot Glaysher
7 years ago (2013-12-09 22:28:14 UTC) #5
On 2013/12/09 22:12:41, Aaron Gable wrote:
> On 2013/12/09 06:40:23, hashimoto wrote:
> > On 2013/12/08 22:30:36, Nico wrote:
> > > (cc'ing maruel in case he's around)
> > 
> > Could you hold this CL?
> > I reverted the CL mentioned above
(https://codereview.chromium.org/107313002).
> 
> erg@ should chime in here. The original CL was written and committed by me
with
> erg@ watching over my shoulder. According to him, dbus_unittests should not be
> run on plain Linux testers. And in fact, reverting the original CL was not a
> good solution a) because the tests *were already broken* and b) because that
> revert is useless without a master restart anyway. I would like to see this CL
> rebased and updated to also remove dbus_unittests so that the tests are fully
> and correctly removed, and then submitted.

I removed the tests because I asked oshima@ if the dbus/ implementation was used
outside of chromeos, and he said no, and that I could not build them locally.
Given that, in the interim, these tests have been fixed, and at least hashimoto@
believes there are actual uses in the Linux Aura world, I'm fine with
dbus_unittests existing in the linux_aura build.

Powered by Google App Engine
This is Rietveld 408576698