Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10981077: change native_client/.../sys/mman.h to native_client/.../bits/mman.h (Closed)

Created:
8 years, 2 months ago by bsy
Modified:
8 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

change native_client/.../sys/mman.h to native_client/.../bits/mman.h A bunch of code included sys/mman.h where mprotect and friends are declared, when they really only need the NACL_ABI_* definitions for PROT_* macros. This wasn't a problem since the declarations in mman.h, even though they didn't have nacl_abi_ prefixes, are standard POSIX type signatures, but in some compilation environments we're seeing additional const attributes used in the system header files, resulting in compile-time errors. This CL removes all uses of native_client/src/.../sys/mman.h from the TCB. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3053 TEST= it builds Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9892

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M src/shared/imc/win/nacl_shm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/shared/platform/linux/nacl_host_dir.c View 1 chunk +1 line, -1 line 0 comments Download
M src/shared/platform/osx/nacl_host_dir.c View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/shared/platform/win/nacl_host_dir.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/linux/nacl_desc_sysv_shm.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_base.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_cond.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_dir.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_imc_shm.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_io.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_mutex.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_semaphore.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/gio/gio_shm.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/gio/gio_shm_test.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/gio/gio_shm_unbounded_test.c View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/include/sys/mman.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/mmap_test.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.c View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/nacl_text.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sehr (please use chromium)
LGTM with removal. http://codereview.chromium.org/10981077/diff/1/src/trusted/service_runtime/include/sys/mman.h File src/trusted/service_runtime/include/sys/mman.h (right): http://codereview.chromium.org/10981077/diff/1/src/trusted/service_runtime/include/sys/mman.h#newcode6 src/trusted/service_runtime/include/sys/mman.h:6: BROKEN Please remove.
8 years, 2 months ago (2012-09-28 22:19:49 UTC) #1
bsy
8 years, 2 months ago (2012-10-01 18:25:07 UTC) #2 
thx.  Committed revision 9892.

http://codereview.chromium.org/10981077/diff/1/src/trusted/service_runtime/in...
File src/trusted/service_runtime/include/sys/mman.h (right):

http://codereview.chromium.org/10981077/diff/1/src/trusted/service_runtime/in...
src/trusted/service_runtime/include/sys/mman.h:6: BROKEN
On 2012/09/28 22:19:49, sehr wrote:
> Please remove.

Done.

Powered by Google App Engine
This is Rietveld 408576698