Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1098103002: [chrome/browser/apps] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tapted, Matt Giuca, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/apps/ BUG=466848 Committed: https://crrev.com/f255ceba28868a75d74d807f726586fdbef87dca Cr-Commit-Position: refs/heads/master@{#326227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/apps/app_url_redirector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-21 09:50:57 UTC) #2
not at google - send to devlin
lgtm
5 years, 8 months ago (2015-04-21 16:12:03 UTC) #3
anujsharma
On 2015/04/21 16:12:03, kalman wrote: > lgtm Thanks Kalman for lgtm.
5 years, 8 months ago (2015-04-22 03:08:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098103002/1
5 years, 8 months ago (2015-04-22 03:09:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 04:21:57 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:22:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f255ceba28868a75d74d807f726586fdbef87dca
Cr-Commit-Position: refs/heads/master@{#326227}

Powered by Google App Engine
This is Rietveld 408576698