Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm

Issue 1098103002: [chrome/browser/apps] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/app_url_redirector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
diff --git a/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm b/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
index 5d61239dbc9074f8359041e92bd7eb10fc3da5ca..0e3465d2d3024eee7ebefc7771c92b243c1047ec 100644
--- a/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
+++ b/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm
@@ -59,7 +59,7 @@ AppShimHostManager::AppShimHostManager()
: did_init_(false) {}
void AppShimHostManager::Init() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!did_init_);
did_init_ = true;
apps::AppShimHandler::SetDefaultHandler(&extension_app_shim_handler_);
@@ -90,7 +90,7 @@ AppShimHostManager::~AppShimHostManager() {
}
void AppShimHostManager::InitOnFileThread() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
base::FilePath user_data_dir;
if (!PathService::Get(chrome::DIR_USER_DATA, &user_data_dir))
return;
@@ -144,7 +144,7 @@ void AppShimHostManager::InitOnFileThread() {
}
void AppShimHostManager::ListenOnIOThread() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!acceptor_->Listen()) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
@@ -154,7 +154,7 @@ void AppShimHostManager::ListenOnIOThread() {
void AppShimHostManager::OnClientConnected(
const IPC::ChannelHandle& handle) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&CreateAppShimHost, handle));
« no previous file with comments | « no previous file | chrome/browser/apps/app_url_redirector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698