[views] Windows with min_size == max_size should be non-resizable.

[views] Windows with min_size == max_size should be non-resizable.


R=mihaip@chromium.org,ben@chromium.org
BUG=152097
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158669

[jeremya, 2012-09-25 00:57:24]

Please review ASAP as I'd like to merge this to M23

[tfarina, 2012-09-25 00:58:49]

Ben seems to be out sick.

Copying Peter for review.

[jeremya, 2012-09-25 01:01:38]

Scott might have something to say about the views code here.

[Peter Kasting, 2012-09-25 01:04:51]

I hate the whole concept of a max window size, but if it already exists, this
change LGTM :/

[Mihai Parparita -not on Chrome, 2012-09-25 05:37:01]

https://codereview.chromium.org/10981013/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/shell_window_views.cc (right):

https://codereview.chromium.org/10981013/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/shell_window_views.cc:494: return
maximum_size_.IsEmpty() || minimum_size_ != maximum_size_;
Will this fix the calculator? It can be resized vertically, just not
horizontally.

[sky, 2012-09-25 15:52:57]

LGTM - assuming it fixes the case you care about.

[Mihai Parparita -not on Chrome, 2012-09-25 17:42:33]

On Mon, Sep 24, 2012 at 10:37 PM, <mihaip@chromium.org> wrote:

> Will this fix the calculator? It can be resized vertically, just not
> horizontally.
>

Jeremy explained that he will change the calculator so that it's not
resizable at all, so this fix is enough for the M23 branch.

LGTM

Mihai

[commit-bot: I haz the power, 2012-09-25 18:10:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10981013/1

[commit-bot: I haz the power, 2012-09-25 18:23:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-25 19:31:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10981013/1

[commit-bot: I haz the power, 2012-09-25 22:13:32]

Change committed as 158669