Update page benchmarking extension to manifest v2 and event page.

Update page benchmarking extension to manifest v2 and event page.

BUG=145278
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162501

[Yoyo Zhou, 2012-09-25 01:30:21]

https://chromiumcodereview.appspot.com/10981008/diff/4001/chrome/common/exten...
File chrome/common/extensions/docs/examples/extensions/benchmark/manifest.json
(right):

https://chromiumcodereview.appspot.com/10981008/diff/4001/chrome/common/exten...
chrome/common/extensions/docs/examples/extensions/benchmark/manifest.json:5:
"content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'",
The unsafe-eval here is unfortunate, but it's required by the jseval part of
jst. I don't know of a good alternative.

[ernestd1, 2012-09-27 02:01:33]

lgtm

https://chromiumcodereview.appspot.com/10981008/diff/4001/chrome/common/exten...
File chrome/common/extensions/docs/examples/extensions/benchmark/options.js
(right):

https://chromiumcodereview.appspot.com/10981008/diff/4001/chrome/common/exten...
chrome/common/extensions/docs/examples/extensions/benchmark/options.js:1: var
max_sample = 0;
should we add licence header to this file?

[Yoyo Zhou, 2012-10-02 21:49:37]

https://chromiumcodereview.appspot.com/10981008/diff/4001/chrome/common/exten...
File chrome/common/extensions/docs/examples/extensions/benchmark/options.js
(right):

https://chromiumcodereview.appspot.com/10981008/diff/4001/chrome/common/exten...
chrome/common/extensions/docs/examples/extensions/benchmark/options.js:1: var
max_sample = 0;
On 2012/09/27 02:01:33, ernestd1 wrote:
> should we add licence header to this file?

Sure. Done to the two .js files.

[commit-bot: I haz the power, 2012-10-17 01:38:06]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Yoyo Zhou, 2012-10-17 01:43:04]

+mpcomplete

[Matt Perry, 2012-10-17 19:38:55]

lgtm

[commit-bot: I haz the power, 2012-10-17 19:40:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/10981008/10001

[commit-bot: I haz the power, 2012-10-17 19:42:40]

Presubmit check for 10981008-10001 failed and returned exit status 1.


Running presubmit commit checks ...
  checking license took a long time: 94140ms

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
 
chrome/common/extensions/docs/examples/extensions/benchmark/jquery/jquery-1.8.2.min.js,
line 2, 93382 chars

License must match:
.*? Copyright (\(c\) )?(2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
 
chrome/common/extensions/docs/examples/extensions/benchmark/jquery/jquery-1.8.2.min.js
\
  chrome/common/extensions/docs/examples/extensions/benchmark/util/sorttable.js

Presubmit checks took 98.6s to calculate.