Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1098043003: Update libsrtp to 1.5.2 (Closed)

Created:
5 years, 8 months ago by fancycode
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libsrtp@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update libsrtp to 1.5.2 This CL updates libsrtp to 1.5.2 which includes the patches that were added manually here before. This CL also adds the latest changes to improve support for compiling on Windows which already landed upstream in libsrtp commit 945eeee980e496ecad0f7df39c8033fe18983921. When this has landed, the remaining issues as seen in CL 981593002 should be fixed and libsrtp should be fine to roll. The libsrtp RNG through BoringSSL is disabled and the default RNG used instead (as was with previous versions of libsrtp). This RNG is only used during self-testing of libsrtp and BoringSSL can't be used inside Chrome from WebRTC as that sandbox doesn't have access to "/dev/urandom" as used by libsrtp. BUG=328475 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -43 lines) Patch
M README.chromium View 2 chunks +1 line, -7 lines 0 comments Download
M libsrtp.gyp View 6 chunks +8 lines, -2 lines 0 comments Download
D srtp/.cvsignore View 0 chunks +-1 lines, --1 lines 0 comments Download
M srtp/CHANGES View 1 chunk +8 lines, -0 lines 0 comments Download
D srtp/Makefile View 0 chunks +-1 lines, --1 lines 0 comments Download
M srtp/Makefile.in View 2 chunks +14 lines, -2 lines 0 comments Download
M srtp/VERSION View 1 chunk +1 line, -1 line 0 comments Download
D srtp/crypto/Makefile View 0 chunks +-1 lines, --1 lines 0 comments Download
M srtp/crypto/Makefile.in View 2 chunks +3 lines, -3 lines 0 comments Download
D srtp/crypto/ae_xfm/xfm.c View 0 chunks +-1 lines, --1 lines 0 comments Download
M srtp/crypto/include/datatypes.h View 1 chunk +1 line, -1 line 0 comments Download
M srtp/crypto/include/sha1.h View 1 chunk +4 lines, -0 lines 0 comments Download
M srtp/crypto/math/datatypes.c View 1 chunk +1 line, -1 line 0 comments Download
M srtp/crypto/test/cipher_driver.c View 6 chunks +9 lines, -6 lines 0 comments Download
M srtp/crypto/test/datatypes_driver.c View 1 chunk +1 line, -1 line 0 comments Download
M srtp/crypto/test/kernel_driver.c View 4 chunks +4 lines, -5 lines 0 comments Download
M srtp/crypto/test/rand_gen.c View 4 chunks +5 lines, -6 lines 0 comments Download
M srtp/crypto/test/rand_gen_soak.c View 4 chunks +3 lines, -4 lines 0 comments Download
D srtp/doc/Makefile View 0 chunks +-1 lines, --1 lines 0 comments Download
M srtp/srtp/srtp.c View 2 chunks +2 lines, -2 lines 0 comments Download
M srtp/test/rdbx_driver.c View 5 chunks +5 lines, -5 lines 0 comments Download
M srtp/test/rtp.c View 1 chunk +1 line, -1 line 0 comments Download
M srtp/test/rtpw.c View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
fancycode
Sorry, I don't know how to create a CL from the SVN checkout as in ...
5 years, 8 months ago (2015-04-20 22:13:03 UTC) #2
jiayl
On 2015/04/20 22:13:03, fancycode wrote: > Sorry, I don't know how to create a CL ...
5 years, 8 months ago (2015-04-20 23:11:50 UTC) #3
fancycode
On 2015/04/20 23:11:50, jiayl wrote: > To create a CL from svn: [...] Thanks, but ...
5 years, 8 months ago (2015-04-20 23:18:53 UTC) #4
fancycode
On 2015/04/20 23:18:53, fancycode wrote: > On 2015/04/20 23:11:50, jiayl wrote: > > To create ...
5 years, 8 months ago (2015-04-23 13:16:59 UTC) #5
jiayl
I think we can continue with this CL. I can help you submit once Justin ...
5 years, 8 months ago (2015-04-23 15:44:54 UTC) #6
fancycode
Ping?
5 years, 7 months ago (2015-04-29 21:24:28 UTC) #7
juberti2
On 2015/04/29 21:24:28, fancycode wrote: > Ping? lgtm
5 years, 7 months ago (2015-04-29 23:01:26 UTC) #8
jiayl
I got 500 response when I tried to commit this. Plus, I use gcl to ...
5 years, 7 months ago (2015-04-30 23:20:40 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 7 months ago (2015-05-06 12:44:56 UTC) #13
kjellander_chromium
On 2015/05/06 12:44:56, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
5 years, 7 months ago (2015-05-06 14:50:14 UTC) #14
jiayl
On 2015/05/06 14:50:14, kjellander wrote: > On 2015/05/06 12:44:56, I haz the power (commit-bot) wrote: ...
5 years, 7 months ago (2015-05-06 16:44:52 UTC) #15
kjellander_chromium
5 years, 7 months ago (2015-05-07 08:39:33 UTC) #16
Message was sent while issue was closed.
On 2015/05/06 16:44:52, jiayl wrote:
> On 2015/05/06 14:50:14, kjellander wrote:
> > On 2015/05/06 12:44:56, I haz the power (commit-bot) wrote:
> > > Commit queue rejected this change because it did not recognize the base
URL.
> > > Please commit your change manually.
> > 
> > Hmm, CQ doesn't seem to work. 
> > Can you try again?
> > 
> > 2 months ago you managed to submit
https://codereview.chromium.org/936663005/
> > and I think gcl should still work.
> > If it doesn't, file a go/chromeinfraticket and point at this CL.
> 
> OK, it worked this time.
> 
> Committed revision 295151.

Great. I added a "Committed:" message manually to this CL description and closed
it.

Powered by Google App Engine
This is Rietveld 408576698