Issue 10979070: Don't run gyp on pure testers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10979070: Don't run gyp on pure testers. (Closed)

Created:
8 years, 2 months ago by Isaac (away)

Modified:
8 years, 2 months ago

Reviewers:
cmp, Yaron

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't run gyp on pure testers. - This moves the gyp phase to bb_compile. This should give a 45 second speedup to testers and will also eliminate local goma failures from breaking testers (which besides a gcc version check in gyp have no dependence on goma) R=yaron BUG=141805 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159212

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	build/android/buildbot/buildbot_functions.sh	View		3 chunks	+7 lines, -8 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://chromiumcodereview.appspot.com/10979070/diff/1/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): https://chromiumcodereview.appspot.com/10979070/diff/1/build/android/buildbot/buildbot_functions.sh#newcode71 build/android/buildbot/buildbot_functions.sh:71: } I take it testers don't need to ...

8 years, 2 months ago (2012-09-28 03:18:55 UTC) #2

Isaac (away)

8 years, 2 months ago (2012-09-28 03:28:13 UTC) #3

+cmp

With this CL we will not be calling runhooks on the testers.  Should be OK since
other testers also do the same.  See M-A's change in rev 134925.

https://chromiumcodereview.appspot.com/10979070/diff/1/build/android/buildbot...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/10979070/diff/1/build/android/buildbot...
build/android/buildbot/buildbot_functions.sh:71: }
On 2012/09/28 03:18:55, Yaron wrote:
> I take it testers don't need to runhooks and have lastchange updated? That
value
> isn't used in reporting any data about the test build that was run?

I don't think so.  We did have that compiler failure for LASTCHANGE that you
fixed a while ago.  I'm going to take a leap of faith.

Expand Messages | Collapse Messages