Don't run gyp on pure testers.

build/android/buildbot/buildbot_functions.sh

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Bash functions used by buildbot annotator scripts for the android
 # build of chromium.  Executing this script should not perform actions
 # other than setting variables and defining of functions.
 
 # Number of jobs on the compile line; e.g.  make -j"${JOBS}"
@@ skipping 19 matching lines @@
     shift
   done
 }
 
 # Function to force-green a bot.
 function bb_force_bot_green_and_exit {
   echo "@@@BUILD_STEP Bot forced green.@@@"
   exit 0
 }
 
-function bb_run_gclient_hooks {
-  gclient runhooks
-}
-
 # Basic setup for all bots to run after a source tree checkout.
 # Args:
 #   $1: source root.
 #   $2 and beyond: key value pairs which are parsed by bb_parse_args.
 function bb_baseline_setup {
   SRC_ROOT="$1"
   # Remove SRC_ROOT param
   shift
   cd $SRC_ROOT
 
   if [[ $BUILDBOT_CLOBBER ]]; then
     echo "@@@BUILD_STEP Clobber@@@"
     # Sdk key expires, delete android folder.
     # crbug.com/145860
     rm -rf ~/.android
     rm -rf "${SRC_ROOT}"/out
     if [ -e "${SRC_ROOT}"/out ] ; then
       echo "Clobber appeared to fail?  ${SRC_ROOT}/out still exists."
       echo "@@@STEP_WARNINGS@@@"
     fi
   fi
 
   echo "@@@BUILD_STEP Environment setup@@@"
   bb_parse_args "$@"
 
   local BUILDTOOL=$(bb_get_json_prop "$FACTORY_PROPERTIES" buildtool)
   if [[ $BUILDTOOL = ninja ]]; then
     export GYP_GENERATORS=ninja
   fi
-  bb_setup_goma_internal
+  export GOMA_DIR=/b/build/goma
   . build/android/envsetup.sh
+}

[Yaron, 2012/09/28 03:18:55]

I take it testers don't need to runhooks and have lastchange updated? That value
isn't used in reporting any data about the test build that was run?

[Isaac (away), 2012/09/28 03:28:13]

I don't think so.  We did have that compiler failure for LASTCHANGE that you
fixed a while ago.  I'm going to take a leap of faith.

+
+function bb_compile_setup {
   local extra_gyp_defines="$(bb_get_json_prop "$FACTORY_PROPERTIES" \
      extra_gyp_defines)"
   export GYP_DEFINES+=" fastbuild=1 $extra_gyp_defines"
   if echo $extra_gyp_defines | grep -q clang; then
     unset CXX_target
   fi
+  bb_setup_goma_internal
   # Should be called only after envsetup is done.
-  bb_run_gclient_hooks
+  gclient runhooks
 }
 
-
 # Setup goma.  Used internally to buildbot_functions.sh.
 function bb_setup_goma_internal {
-  export GOMA_DIR=/b/build/goma
   export GOMA_API_KEY_FILE=${GOMA_DIR}/goma.key
   export GOMA_COMPILER_PROXY_DAEMON_MODE=true
   export GOMA_COMPILER_PROXY_RPC_TIMEOUT_SECS=300
 
   echo "Killing old goma processes"
   ${GOMA_DIR}/goma_ctl.sh stop || true
   killall -9 compiler_proxy || true
 
   echo "Starting goma"
   ${GOMA_DIR}/goma_ctl.sh start
@@ skipping 45 matching lines @@
 
 # Build using ninja.
 function bb_goma_ninja {
   echo "Using ninja to build."
   local TARGET=$1
   ninja -C out/$BUILDTYPE -j120 -l20 $TARGET
 }
 
 # Compile step
 function bb_compile {
+  bb_compile_setup
   # This must be named 'compile', not 'Compile', for CQ interaction.
   # Talk to maruel for details.
   echo "@@@BUILD_STEP compile@@@"
 
   BUILDTOOL=$(bb_get_json_prop "$FACTORY_PROPERTIES" buildtool)
   if [[ $BUILDTOOL = ninja ]]; then
     bb_goma_ninja All
   else
     bb_goma_make
   fi
@@ skipping 135 matching lines @@
   )
 }
 
 # Retrieve a packed json property using python
 function bb_get_json_prop {
   local JSON="$1"
   local PROP="$2"
 
   python -c "import json; print json.loads('$JSON').get('$PROP', '')"
 }