Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1877)

Unified Diff: dart/tools/testing/dart/test_progress.dart

Issue 10977054: Separate compile-time and runtime errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment fixes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/multitest.dart ('k') | dart/tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_progress.dart
diff --git a/dart/tools/testing/dart/test_progress.dart b/dart/tools/testing/dart/test_progress.dart
index 7b99f678cd4627d3d0e3bfd3d539f532feb5d629..d157f23935a521a94f0a1c5aeaeb885f2e513736 100644
--- a/dart/tools/testing/dart/test_progress.dart
+++ b/dart/tools/testing/dart/test_progress.dart
@@ -124,6 +124,18 @@ class ProgressIndicator {
}
output.add(expected.toString());
output.add('Actual: ${test.output.result}');
+ if (test.info != null) {
+ if (test.output.incomplete && !test.info.hasCompileError) {
+ output.add('Unexpected compile-time error.');
+ } else {
+ if (test.info.hasCompileError) {
+ output.add('Compile-time error expected.');
+ }
+ if (test.info.hasRuntimeError) {
+ output.add('Runtime error expected.');
+ }
+ }
+ }
if (!test.output.diagnostics.isEmpty()) {
String prefix = 'diagnostics:';
for (var s in test.output.diagnostics) {
« no previous file with comments | « dart/tools/testing/dart/multitest.dart ('k') | dart/tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698