Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: dart/tools/testing/dart/multitest.dart

Issue 10977054: Separate compile-time and runtime errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment fixes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/language/language_dart2js.status ('k') | dart/tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/multitest.dart
diff --git a/dart/tools/testing/dart/multitest.dart b/dart/tools/testing/dart/multitest.dart
index 418bd3803088d28b2a1aa22438699eef53e4a13c..93a9f0af6568bb10c8d4f9a59568372ea141f25e 100644
--- a/dart/tools/testing/dart/multitest.dart
+++ b/dart/tools/testing/dart/multitest.dart
@@ -191,8 +191,6 @@ Set<Path> _findAllRelativeImports(Path topLibrary) {
void DoMultitest(Path filePath,
String outputDir,
Path suiteDir,
- // TODO(zundel): Are the boolean flags now redundant
- // with the 'multitestOutcome' field?
CreateTest doTest,
VoidFunction multitestDone) {
// Each new test is a single String value in the Map tests.
@@ -234,14 +232,13 @@ void DoMultitest(Path filePath,
Set<String> outcome = outcomes[key];
bool enableFatalTypeErrors = outcome.contains('static type warning');
bool hasRuntimeErrors = outcome.contains('runtime error');
- bool isNegative = hasRuntimeErrors
- || outcome.contains('compile-time error');
+ bool hasCompileError = outcome.contains('compile-time error');
bool isNegativeIfChecked = outcome.contains('dynamic type error');
doTest(multitestFilename,
- isNegative,
+ hasCompileError,
+ hasRuntimeErrors,
isNegativeIfChecked: isNegativeIfChecked,
hasFatalTypeErrors: enableFatalTypeErrors,
- hasRuntimeErrors: hasRuntimeErrors,
multitestOutcome: outcome);
}
multitestDone();
« no previous file with comments | « dart/tests/language/language_dart2js.status ('k') | dart/tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698