queryCommandSupported() should return 'true' for cut/copy/paste editing commands

queryCommandSupported() should return 'true' for cut/copy/paste editing commands

As per spec [1],  all commands defined in editing specification must be
supported. Support for Cut, Copy and Paste commands is already implemented
so, blink should return 'true'.

[1] https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#supported-commands


BUG=476508

[Abhijeet Kandalkar Slow, 2015-04-17 13:05:49]

abhijeet.k@samsung.com changed reviewers:
+ dcheng@chromium.org, vivekg@chromium.org

[Abhijeet Kandalkar Slow, 2015-04-17 13:07:01]

Please review patch.

[dcheng, 2015-04-20 17:09:03]

https://codereview.chromium.org/1097693003/diff/20001/Source/core/editing/Edi...
File Source/core/editing/Editor.h (right):

https://codereview.chromium.org/1097693003/diff/20001/Source/core/editing/Edi...
Source/core/editing/Editor.h:132: bool isSupported(bool enabled = false) const;
I don't really understand why we added this default arg. It seems wrong.

[Abhijeet Kandalkar Slow, 2015-04-21 14:14:33]

https://codereview.chromium.org/1097693003/diff/20001/Source/core/editing/Edi...
File Source/core/editing/Editor.h (right):

https://codereview.chromium.org/1097693003/diff/20001/Source/core/editing/Edi...
Source/core/editing/Editor.h:132: bool isSupported(bool enabled = false) const;
On 2015/04/20 17:09:03, dcheng wrote:
> I don't really understand why we added this default arg. It seems wrong.

current implementation of isSupported() check whether javaScript can access
clipboard. As it is not allowed it is returning false. 
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

isSupported() should only check whether command is present in CommandMap. If
command is supported, isEnabled() should check whether is it actually available
to use.

Default flag is added to identify whether isSupported() is invoked by
isEnabled(). If it is invoked by isEnabled() then only check whether javaScript
can access clipboard.

[dcheng, 2015-04-21 14:16:23]

Right, shouldn't we be fixing EditorCommand.cpp instead of changing
isSupported() broadly like that?

[Abhijeet Kandalkar Slow, 2015-04-21 15:07:42]

DONE.Moved all changes to EditorCommand.cpp
Please review changes(Set-3)

[dcheng, 2015-04-21 15:27:15]

I mean, I think it would be more appropriate to modify the implementations of
supportedCopyCut, enabledCopy, etc?

[dcheng, 2015-04-21 15:27:47]

(Hit send too early.)

With those changes, why would we still want to change
Editor::Command::isSupported, etc?

[Abhijeet Kandalkar Slow, 2015-05-19 11:13:03]

On 2015/04/21 15:27:47, dcheng wrote:
> (Hit send too early.)
> 
> With those changes, why would we still want to change
> Editor::Command::isSupported, etc?

Modified as per review comments.
If we are reaching till supportedCopyCut() it means command is supported.
While deciding whether command is enabled or not, browser should check JS
access to clipboard and user gesture.

Please review changes.

[dcheng, 2015-05-19 16:31:45]

This change looks much better.

However, I think we need to clarify some spec questions. The checks for
queryCommandEnabled("copy"|"cut"|"paste") don't actually match the checks for
when we fire these events: we still fire paste events even if we aren't in an
editable area, for example. I'll file a spec bug to try to get some clarity on
this issue...

[Abhijeet Kandalkar Slow, 2015-07-06 05:56:10]

On 2015/05/19 16:31:45, dcheng wrote:
> This change looks much better.
> 
> However, I think we need to clarify some spec questions. The checks for
> queryCommandEnabled("copy"|"cut"|"paste") don't actually match the checks for
> when we fire these events: we still fire paste events even if we aren't in an
> editable area, for example. I'll file a spec bug to try to get some clarity on
> this issue...

@dcheng, Could you please share spec bug URL/ID related to this issue.

[dcheng, 2015-07-06 17:40:11]

https://github.com/w3c/clipboard-apis/issues/4