Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1097683002: Clean up output of heap object tracing (Closed)

Created:
5 years, 8 months ago by ulan
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up output of heap object tracing BUG= Committed: https://crrev.com/068a6afb4494e12c9ad6bc93f1e6eae792dbc2d8 Cr-Commit-Position: refs/heads/master@{#27929}

Patch Set 1 #

Patch Set 2 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL
5 years, 8 months ago (2015-04-17 09:09:21 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-17 09:10:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097683002/1
5 years, 8 months ago (2015-04-17 09:15:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/1781)
5 years, 8 months ago (2015-04-17 09:25:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097683002/20001
5 years, 8 months ago (2015-04-18 08:35:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-18 09:21:20 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-18 09:21:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/068a6afb4494e12c9ad6bc93f1e6eae792dbc2d8
Cr-Commit-Position: refs/heads/master@{#27929}

Powered by Google App Engine
This is Rietveld 408576698