Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: src/heap/heap.cc

Issue 1097683002: Clean up output of heap object tracing (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compile error Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 82589c7fd9b1b3a8dee83ace222ef997506f0959..c1cb9b90a88af2726b05164b91936b405a0098d5 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -6291,10 +6291,9 @@ void Heap::ClearObjectStats(bool clear_last_time_stats) {
static base::LazyMutex object_stats_mutex = LAZY_MUTEX_INITIALIZER;
-static void TraceObjectStat(const char* name, int count, int size) {
- if (size > 0) {
- PrintF("%40s\tcount= %6d\t size= %6d kb\n", name, count, size);
- }
+void Heap::TraceObjectStat(const char* name, int count, int size, double time) {
+ PrintPID("heap:%p, time:%f, gc:%d, type:%s, count:%d, size:%d\n",
+ static_cast<void*>(this), time, ms_count_, name, count, size);
}
@@ -6304,25 +6303,26 @@ void Heap::TraceObjectStats() {
int count;
int size;
int total_size = 0;
+ double time = isolate_->time_millis_since_init();
#define TRACE_OBJECT_COUNT(name) \
count = static_cast<int>(object_counts_[name]); \
size = static_cast<int>(object_sizes_[name]) / KB; \
total_size += size; \
- TraceObjectStat(#name, count, size);
+ TraceObjectStat(#name, count, size, time);
INSTANCE_TYPE_LIST(TRACE_OBJECT_COUNT)
#undef TRACE_OBJECT_COUNT
#define TRACE_OBJECT_COUNT(name) \
index = FIRST_CODE_KIND_SUB_TYPE + Code::name; \
count = static_cast<int>(object_counts_[index]); \
size = static_cast<int>(object_sizes_[index]) / KB; \
- TraceObjectStat("CODE_" #name, count, size);
+ TraceObjectStat("*CODE_" #name, count, size, time);
CODE_KIND_LIST(TRACE_OBJECT_COUNT)
#undef TRACE_OBJECT_COUNT
#define TRACE_OBJECT_COUNT(name) \
index = FIRST_FIXED_ARRAY_SUB_TYPE + name; \
count = static_cast<int>(object_counts_[index]); \
size = static_cast<int>(object_sizes_[index]) / KB; \
- TraceObjectStat("FIXED_ARRAY_" #name, count, size);
+ TraceObjectStat("*FIXED_ARRAY_" #name, count, size, time);
FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(TRACE_OBJECT_COUNT)
#undef TRACE_OBJECT_COUNT
#define TRACE_OBJECT_COUNT(name) \
@@ -6330,10 +6330,9 @@ void Heap::TraceObjectStats() {
FIRST_CODE_AGE_SUB_TYPE + Code::k##name##CodeAge - Code::kFirstCodeAge; \
count = static_cast<int>(object_counts_[index]); \
size = static_cast<int>(object_sizes_[index]) / KB; \
- TraceObjectStat("CODE_AGE_" #name, count, size);
+ TraceObjectStat("*CODE_AGE_" #name, count, size, time);
CODE_AGE_LIST_COMPLETE(TRACE_OBJECT_COUNT)
#undef TRACE_OBJECT_COUNT
- PrintF("Total size= %d kb\n", total_size);
}
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698