media/audio/win/core_audio_util_win.cc - Issue 1097553003: Switch to STA mode for audio thread and WASAPI I/O streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/win/core_audio_util_win.cc

Issue 1097553003: Switch to STA mode for audio thread and WASAPI I/O streams. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/audio/win/audio_low_latency_output_win.cc ('K') | « media/audio/win/audio_output_win_unittest.cc ('k') | media/audio/win/core_audio_util_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/win/core_audio_util_win.cc

diff --git a/media/audio/win/core_audio_util_win.cc b/media/audio/win/core_audio_util_win.cc

index 53530dfc998382d46ef6cbaf26031d1493ee0a79..4f72564ee5a6863fe675fe47db6abf7c249aec84 100644

--- a/media/audio/win/core_audio_util_win.cc

+++ b/media/audio/win/core_audio_util_win.cc

@@ -178,10 +178,12 @@ static ScopedComPtr<IMMDeviceEnumerator> CreateDeviceEnumeratorInternal() {

// fail with CO_E_NOTINITIALIZED in combination with certain 3rd party

// modules. Calling CoInitializeEx is an attempt to resolve the reported

// issues. See http://crbug.com/378465 for details.

- hr = CoInitializeEx(NULL, COINIT_MULTITHREADED);

+ hr = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);

if (SUCCEEDED(hr)) {

- hr = device_enumerator.CreateInstance(__uuidof(MMDeviceEnumerator),

- NULL, CLSCTX_INPROC_SERVER);

+ hr = device_enumerator.CreateInstance(__uuidof(MMDeviceEnumerator), NULL,

+ CLSCTX_INPROC_SERVER);

+ } else {

+ LOG(ERROR) << "CoCreateInstance still failed! " << std::hex << hr;

}

return device_enumerator;