Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1097503002: Add the network service as a data dependency of html_viewer for Android. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the network service as a data dependency of html_viewer for Android. The corresponding desktop CL: https://codereview.chromium.org/1090753002 BUG=NONE TEST=Building html_viewer from scratch also builds the network service. R=sky@chromium.org Committed: https://crrev.com/96626920573e30a2cd02040b7ccec2c56f38b4db Cr-Commit-Position: refs/heads/master@{#325501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/services/html_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
msw
Hey Scott, please take a look; thanks! (sorry for splitting desktop and android CLs)
5 years, 8 months ago (2015-04-16 18:29:10 UTC) #1
sky
LGTM
5 years, 8 months ago (2015-04-16 19:08:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097503002/1
5 years, 8 months ago (2015-04-16 19:11:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 19:35:30 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 19:37:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96626920573e30a2cd02040b7ccec2c56f38b4db
Cr-Commit-Position: refs/heads/master@{#325501}

Powered by Google App Engine
This is Rietveld 408576698