Issue 1090753002: Add the network service as a data dependency of html_viewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1090753002: Add the network service as a data dependency of html_viewer. (Closed)

Created:
5 years, 8 months ago by msw

Modified:
5 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add the network service as a data dependency of html_viewer. BUG=NONE TEST=Building html_viewer from scratch also builds the network service. R=sky@chromium.org Committed: https://crrev.com/8be9cf018fe5de00f16c74886079c66d1a11919d Cr-Commit-Position: refs/heads/master@{#325342}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	mojo/services/html_viewer/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msw

Hey Scott, please take a look; thanks! (I'm investigating something similar for Android too)

5 years, 8 months ago (2015-04-15 22:47:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090753002/1

5 years, 8 months ago (2015-04-15 23:05:26 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-15 23:31:38 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8be9cf018fe5de00f16c74886079c66d1a11919d
Cr-Commit-Position: refs/heads/master@{#325342}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages