tools/perf/measurements/thread_times.py - Issue 1097463004: Add key_idle_power_cases for ensuring idle activity on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/thread_times.py

Issue 1097463004: Add key_idle_power_cases for ensuring idle activity on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/thread_times.py

diff --git a/tools/perf/measurements/thread_times.py b/tools/perf/measurements/thread_times.py

index 70c1f0912fb1ad35d4bcad747712d646f862538c..12cd4cdfedebd887c0480486ae4abfbf525f0b73 100644

--- a/tools/perf/measurements/thread_times.py

+++ b/tools/perf/measurements/thread_times.py

@@ -11,10 +11,11 @@ from metrics import timeline

class ThreadTimes(page_test.PageTest):

- def __init__(self, report_silk_details=False):

+ def __init__(self, report_silk_details=False, measure_per_frame=True):

super(ThreadTimes, self).__init__()

self._timeline_controller = None

self._report_silk_details = report_silk_details

+ self._measure_per_frame = measure_per_frame

def WillNavigateToPage(self, page, tab):

self._timeline_controller = timeline_controller.TimelineController()

@@ -31,7 +32,7 @@ class ThreadTimes(page_test.PageTest):

def ValidateAndMeasurePage(self, page, tab, results):

self._timeline_controller.Stop(tab, results)

- metric = timeline.ThreadTimesTimelineMetric()

+ metric = timeline.ThreadTimesTimelineMetric(self._measure_per_frame)

renderer_thread = \

self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)

if self._report_silk_details:

« no previous file with comments | « tools/perf/benchmarks/thread_times.py ('k') | tools/perf/metrics/timeline.py » ('j') | tools/perf/page_sets/key_power_cases.py » ('J')