Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: src/heap.cc

Issue 10974006: Improve --trace-gc-verbose to show sum of all spaces. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index 0515019630ad1d7e69f0f3b788072b50b090681c..d98f8062b6f5281adac6468bf91b8b75d9420300 100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -371,6 +371,12 @@ void Heap::PrintShortHeapStatistics() {
lo_space_->SizeOfObjects() / KB,
lo_space_->Available() / KB,
lo_space_->CommittedMemory() / KB);
+ PrintPID("Sum of all spaces, used: %6" V8_PTR_PREFIX "d KB"
Michael Starzinger 2012/09/24 11:13:14 I am not sure how to name this line, maybe you hav
ulan 2012/09/24 11:16:21 Maybe just "All spaces" or "Total spaces"?
Michael Starzinger 2012/09/24 13:02:46 Done. As discussed offline we settled for "All spa
+ ", available: %6" V8_PTR_PREFIX "d KB"
+ ", committed: %6" V8_PTR_PREFIX "d KB\n",
+ this->SizeOfObjects() / KB,
+ this->Available() / KB,
+ this->CommittedMemory() / KB);
PrintPID("Total time spent in GC : %d ms\n", total_gc_time_ms_);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698