Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(129)

Issue 10974006: Improve --trace-gc-verbose to show sum of all spaces. (Closed)

Created:
7 years ago by Michael Starzinger
Modified:
7 years ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Improve --trace-gc-verbose to show sum of all spaces. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12597

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/heap.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
https://codereview.chromium.org/10974006/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/10974006/diff/1/src/heap.cc#newcode374 src/heap.cc:374: PrintPID("Sum of all spaces, used: %6" V8_PTR_PREFIX "d KB" ...
7 years ago (2012-09-24 11:13:14 UTC) #1
ulan
lgtm https://codereview.chromium.org/10974006/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/10974006/diff/1/src/heap.cc#newcode374 src/heap.cc:374: PrintPID("Sum of all spaces, used: %6" V8_PTR_PREFIX "d ...
7 years ago (2012-09-24 11:16:21 UTC) #2
Michael Starzinger
7 years ago (2012-09-24 13:02:46 UTC) #3
Addressed comments. Landing.

https://codereview.chromium.org/10974006/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/10974006/diff/1/src/heap.cc#newcode374
src/heap.cc:374: PrintPID("Sum of all spaces,  used: %6" V8_PTR_PREFIX "d KB"
On 2012/09/24 11:16:21, ulan wrote:
> On 2012/09/24 11:13:14, Michael Starzinger wrote:
> > I am not sure how to name this line, maybe you have a better description.
> 
> Maybe just "All spaces" or "Total spaces"?

Done. As discussed offline we settled for "All spaces".

Powered by Google App Engine
This is Rietveld 408576698