Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1097393005: Wrap content TextView widget in Share Dialogue (Closed)

Created:
5 years, 8 months ago by Swati
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ellipsize TextView widget in Share Dialogue In Share Dialogue layout xml, the TextView widget is not independent of the device scale factor i.e. in case of multi-line text for larger font size preference the text gets truncated. Added ellipsize support to this widget. BUG=410205 Committed: https://crrev.com/ff0b669df07b984301f73694a1b8ae29a24039a5 Cr-Commit-Position: refs/heads/master@{#327448}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Modified the TextView widget height to wrap_content #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/layout/share_dialog_item.xml View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Swati
Please review. Thanks
5 years, 8 months ago (2015-04-22 12:27:41 UTC) #2
Ted C
+aurimas -- can you take a look Also, I looked at the CLA signers, and ...
5 years, 8 months ago (2015-04-24 17:57:00 UTC) #4
aurimas (slooooooooow)
https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/layout/share_dialog_item.xml File chrome/android/java/res/layout/share_dialog_item.xml (right): https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/layout/share_dialog_item.xml#newcode21 chrome/android/java/res/layout/share_dialog_item.xml:21: android:layout_height="48dp" Can we do wrap_content for layout_height instead of ...
5 years, 8 months ago (2015-04-24 18:03:14 UTC) #5
Swati
On 2015/04/24 18:03:14, aurimas wrote: > https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/layout/share_dialog_item.xml > File chrome/android/java/res/layout/share_dialog_item.xml (right): > > https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/layout/share_dialog_item.xml#newcode21 > ...
5 years, 8 months ago (2015-04-27 05:42:02 UTC) #6
aurimas (slooooooooow)
On 2015/04/27 at 05:42:02, swa.jaiswal wrote: > On 2015/04/24 18:03:14, aurimas wrote: > > https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/layout/share_dialog_item.xml ...
5 years, 8 months ago (2015-04-27 22:51:02 UTC) #7
Swati
Please review.
5 years, 8 months ago (2015-04-28 05:28:35 UTC) #8
Swati
On 2015/04/24 17:57:00, Ted C wrote: > +aurimas -- can you take a look > ...
5 years, 8 months ago (2015-04-28 05:41:11 UTC) #9
aurimas (slooooooooow)
lgtm
5 years, 7 months ago (2015-04-28 20:55:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097393005/20001
5 years, 7 months ago (2015-04-29 03:58:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 07:55:29 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 07:56:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff0b669df07b984301f73694a1b8ae29a24039a5
Cr-Commit-Position: refs/heads/master@{#327448}

Powered by Google App Engine
This is Rietveld 408576698