Wrap content TextView widget in Share Dialogue

Ellipsize TextView widget in Share Dialogue

In Share Dialogue layout xml, the TextView widget is not independent of
the device scale factor i.e. in case of multi-line text for larger font size
preference the text gets truncated. Added ellipsize support to this widget.

BUG=410205
Committed: https://crrev.com/ff0b669df07b984301f73694a1b8ae29a24039a5
Cr-Commit-Position: refs/heads/master@{#327448}

[Swati, 2015-04-22 12:27:41]

swa.jaiswal@samsung.com changed reviewers:
+ l.gombos@chromium.org, tedchoc@chromium.org

[Swati, 2015-04-22 12:27:41]

Please review.
Thanks

[Ted C, 2015-04-24 17:57:00]

tedchoc@chromium.org changed reviewers:
+ aurimas@chromium.org

[Ted C, 2015-04-24 17:57:00]

+aurimas -- can you take a look

Also, I looked at the CLA signers, and I don't see your username.  Did you
submit the request to get it added to the samsung CLA signers?

[aurimas (slooooooooow), 2015-04-24 18:03:14]

https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/share_dialog_item.xml (right):

https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/share_dialog_item.xml:21:
android:layout_height="48dp"
Can we do wrap_content for layout_height instead of making this one row?

[Swati, 2015-04-27 05:42:02]

On 2015/04/24 18:03:14, aurimas wrote:
>
https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/lay...
> File chrome/android/java/res/layout/share_dialog_item.xml (right):
> 
>
https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/lay...
> chrome/android/java/res/layout/share_dialog_item.xml:21:
> android:layout_height="48dp"
> Can we do wrap_content for layout_height instead of making this one row?

Yes we can apply wrap_content to fix the issue. 

We will also have to remove the android:maxLines = 2 constraint to handle
scenarios where the text size is greater than 2 lines.

Please check the screen shots attached in the bug.

Image 1: wrap_content + maxLines (Original Text = "File Commander Wi-Fi Direct™
My text to increase line size!!")
Image 2: wrap_content only

Image 1 we can see that the text gets truncated due to maxLines constraint.
Image 2 no truncation but we can observe that TextView Layout is not consistent
with respect to others.

So shall I go ahead with the wrap_content only change ?

[aurimas (slooooooooow), 2015-04-27 22:51:02]

On 2015/04/27 at 05:42:02, swa.jaiswal wrote:
> On 2015/04/24 18:03:14, aurimas wrote:
> >
https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/lay...
> > File chrome/android/java/res/layout/share_dialog_item.xml (right):
> > 
> >
https://codereview.chromium.org/1097393005/diff/1/chrome/android/java/res/lay...
> > chrome/android/java/res/layout/share_dialog_item.xml:21:
> > android:layout_height="48dp"
> > Can we do wrap_content for layout_height instead of making this one row?
> 
> Yes we can apply wrap_content to fix the issue. 
> 
> We will also have to remove the android:maxLines = 2 constraint to handle
scenarios where the text size is greater than 2 lines.
> 
> Please check the screen shots attached in the bug.
> 
> Image 1: wrap_content + maxLines (Original Text = "File Commander Wi-Fi
Direct™ My text to increase line size!!")
> Image 2: wrap_content only
> 
> Image 1 we can see that the text gets truncated due to maxLines constraint.
> Image 2 no truncation but we can observe that TextView Layout is not
consistent with respect to others.
> 
> So shall I go ahead with the wrap_content only change ?

Sure wrap_content (image 2) seems reasonable. Please update your change to do
that.

[Swati, 2015-04-28 05:28:35]

Please review.

[Swati, 2015-04-28 05:41:11]

On 2015/04/24 17:57:00, Ted C wrote:
> +aurimas -- can you take a look
> 
> Also, I looked at the CLA signers, and I don't see your username.  Did you
> submit the request to get it added to the samsung CLA signers?

I submitted the request and it is approved and added now.

[aurimas (slooooooooow), 2015-04-28 20:55:18]

lgtm

[Swati, 2015-04-29 03:57:51]

The CQ bit was checked by swa.jaiswal@samsung.com

[commit-bot: I haz the power, 2015-04-29 03:58:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097393005/20001

[commit-bot: I haz the power, 2015-04-29 07:55:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 07:56:21]

Patchset 2 (id:??) landed as
https://crrev.com/ff0b669df07b984301f73694a1b8ae29a24039a5
Cr-Commit-Position: refs/heads/master@{#327448}