chrome/android/java/res/layout/share_dialog_item.xml - Issue 1097393005: Wrap content TextView widget in Share Dialogue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/share_dialog_item.xml

Issue 1097393005: Wrap content TextView widget in Share Dialogue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified the TextView widget height to wrap_content Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

8 android:layout_width="match_parent"	8 android:layout_width="match_parent"

9 android:layout_height="wrap_content"	9 android:layout_height="wrap_content"

10 android:background="?attr/selectableItemBackground"	10 android:background="?attr/selectableItemBackground"

11 android:orientation="horizontal" >	11 android:orientation="horizontal" >

12 <ImageView android:id="@+id/icon"	12 <ImageView android:id="@+id/icon"

13 android:layout_width="48dp"	13 android:layout_width="48dp"

14 android:layout_height="48dp"	14 android:layout_height="48dp"

15 android:layout_marginStart="12dp"	15 android:layout_marginStart="12dp"

16 android:padding="4dp"	16 android:padding="4dp"

17 android:scaleType="fitCenter"	17 android:scaleType="fitCenter"

18 android:contentDescription="@null" />	18 android:contentDescription="@null" />

19 <TextView android:id="@+id/text"	19 <TextView android:id="@+id/text"

20 android:layout_width="wrap_content"	20 android:layout_width="wrap_content"

21 android:layout_height="48dp"	21 android:layout_height="wrap_content"

22 android:gravity="start\|center_vertical"	22 android:gravity="start\|center_vertical"

23 android:layout_marginStart="12dp"	23 android:layout_marginStart="12dp"

24 android:maxLines="2"

25 android:textAppearance="?android:attr/textAppearanceMedium" />	24 android:textAppearance="?android:attr/textAppearanceMedium" />

26 </LinearLayout>	25 </LinearLayout>

OLD	NEW