Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher.h

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail
Patch Set: Another approach - split Start to Init and Start Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bitmap_fetcher/bitmap_fetcher.h
diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher.h b/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
index 11055eaf61a50e8aaf7a051e629858c5435e7de5..0f7f8c1ce4008a3c30786fcf5c950cc3ebca2654 100644
--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
@@ -29,6 +29,7 @@ class BitmapFetcher : public net::URLFetcherDelegate,
~BitmapFetcher() override;
const GURL& url() const { return url_; }
+ net::URLFetcher* url_fetcher() { return url_fetcher_.get(); }
// Start fetching the URL with the fetcher. The delegate is notified
Peter Kasting 2015/04/24 23:18:21 This comment needs updating. In particular you sh
// asynchronously when done. Start may be called more than once in some
@@ -36,10 +37,12 @@ class BitmapFetcher : public net::URLFetcherDelegate,
// already in progress. Arguments are used to configure the internal fetcher.
// Values for |load_flags| are defined in net/base/load_flags.h. In general,
// |net::LOAD_NORMAL| is appropriate.
- void Start(net::URLRequestContextGetter* request_context,
- const std::string& referrer,
- net::URLRequest::ReferrerPolicy referrer_policy,
- int load_flags);
+ void Init(net::URLRequestContextGetter* request_context,
+ const std::string& referrer,
+ net::URLRequest::ReferrerPolicy referrer_policy,
+ int load_flags);
+
+ void Start();
Peter Kasting 2015/04/24 23:18:21 You should add a comment here.
// Methods inherited from URLFetcherDelegate
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698