chrome/browser/bitmap_fetcher/bitmap_fetcher.cc - Issue 1097383005: Add possibility to define data callback to BitmapFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher.cc

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail

Patch Set: Another approach - split Start to Init and Start Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bitmap_fetcher/bitmap_fetcher.h ('K') | « chrome/browser/bitmap_fetcher/bitmap_fetcher.h ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bitmap_fetcher/bitmap_fetcher.cc

diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc b/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc

index e413fa1a8e35de6643623c4434156ea5de9f9941..76d24cc89b20f0acf0988c435de53d695d99d204 100644

--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc

+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher.cc

@@ -21,10 +21,10 @@ BitmapFetcher::BitmapFetcher(const GURL& url, BitmapFetcherDelegate* delegate)

BitmapFetcher::~BitmapFetcher() {

}

-void BitmapFetcher::Start(net::URLRequestContextGetter* request_context,

- const std::string& referrer,

- net::URLRequest::ReferrerPolicy referrer_policy,

- int load_flags) {

+void BitmapFetcher::Init(net::URLRequestContextGetter* request_context,

+ const std::string& referrer,

+ net::URLRequest::ReferrerPolicy referrer_policy,

+ int load_flags) {

if (url_fetcher_ != NULL)

return;

@@ -33,6 +33,9 @@ void BitmapFetcher::Start(net::URLRequestContextGetter* request_context,

url_fetcher_->SetReferrer(referrer);

url_fetcher_->SetReferrerPolicy(referrer_policy);

url_fetcher_->SetLoadFlags(load_flags);

+void BitmapFetcher::Start() {

url_fetcher_->Start();

}