Issue 1097303002: Properly set WebURLRequest::FrameType for opened windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1097303002: Properly set WebURLRequest::FrameType for opened windows. (Closed)

Created:
5 years, 8 months ago by Mike West

Modified:
5 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Properly set WebURLRequest::FrameType for opened windows. These should have an "auxiliary" context, per Fetch. This will allow us to distinguish between main frame navigations and window openings to make certain policy decisions (first-party cookies, etc). BUG=459154 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194131

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	Source/core/loader/FrameLoader.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	Source/core/page/CreateWindow.cpp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mike West

Splitting this out from https://codereview.chromium.org/1071893003, as you suggested. No tests, as there shouldn't be any ...

5 years, 8 months ago (2015-04-21 11:55:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097303002/1

5 years, 8 months ago (2015-04-21 12:46:53 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 14:36:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194131

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages