Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 1097303002: Properly set WebURLRequest::FrameType for opened windows. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index 43f34f747227da88f87d973ba01e3a1c02534028..43cc63a3a930827039841256b131aca78e7e48f6 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -792,10 +792,12 @@ void FrameLoader::load(const FrameLoadRequest& passedRequest)
FrameLoadType newLoadType = determineFrameLoadType(request);
NavigationPolicy policy = navigationPolicyForRequest(request);
if (shouldOpenInNewWindow(targetFrame.get(), request, policy)) {
- if (policy == NavigationPolicyDownload)
+ if (policy == NavigationPolicyDownload) {
client()->loadURLExternally(request.resourceRequest(), NavigationPolicyDownload);
- else
+ } else {
+ request.resourceRequest().setFrameType(WebURLRequest::FrameTypeAuxiliary);
createWindowForRequest(request, *m_frame, policy, request.shouldSendReferrer());
+ }
return;
}
« no previous file with comments | « no previous file | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698