[Reland] Implement Custom Element's class side inheritance

[Reland] Implement Custom Element's class side inheritance

Custom element should set __proto__ internal property of the generated
constructor. __proto__ should be set to base class object.
As class inheritance is supported in DOM elements, it should also be
supported in Custom elements.

BUG=271466, 443369, 478329
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194296

[deepak.s, 2015-04-21 08:27:50]

deepak.s@samsung.com changed reviewers:
+ dominicc@chromium.org, esprehn@chromium.org, haraken@chromium.org,
jkummerow@chromium.org

[deepak.s, 2015-04-21 08:27:50]

Using maybe version of v8::Object::Get.

PTAL?
Thanks!

[haraken, 2015-04-21 08:35:38]

What's a diff from the previous CL?

[deepak.s, 2015-04-21 08:37:04]

https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
File Source/bindings/core/v8/CustomElementConstructorBuilder.cpp (right):

https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
Source/bindings/core/v8/CustomElementConstructorBuilder.cpp:204: if
(!m_prototype->Get(context, constructorKey).ToLocal(&constructorPrototype))
Now, we are using maybe version of *Get*.

[haraken, 2015-04-21 08:39:41]

On 2015/04/21 08:37:04, deepak.s wrote:
>
https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
> File Source/bindings/core/v8/CustomElementConstructorBuilder.cpp (right):
> 
>
https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
> Source/bindings/core/v8/CustomElementConstructorBuilder.cpp:204: if
> (!m_prototype->Get(context, constructorKey).ToLocal(&constructorPrototype))
> Now, we are using maybe version of *Get*.

Thanks, LGTM

[vivekg, 2015-04-21 08:44:17]

On 2015/04/21 at 08:37:04, deepak.s wrote:
>
https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
> File Source/bindings/core/v8/CustomElementConstructorBuilder.cpp (right):
> 
>
https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
> Source/bindings/core/v8/CustomElementConstructorBuilder.cpp:204: if
(!m_prototype->Get(context, constructorKey).ToLocal(&constructorPrototype))
> Now, we are using maybe version of *Get*.

Thats great. Will it be possible for us to add even a layout test based on the
minimum test case from the fuzzer to validate this? [1]

[1]
https://cluster-fuzz.appspot.com/viewer?blob_key=AMIfv96kq7dCUbMoIAtn-NLi9psH...

[deepak.s, 2015-04-21 08:49:15]

On 2015/04/21 08:44:17, vivekg_ wrote:
> On 2015/04/21 at 08:37:04, deepak.s wrote:
> >
>
https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
> > File Source/bindings/core/v8/CustomElementConstructorBuilder.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1097243002/diff/1/Source/bindings/core/v8/Cus...
> > Source/bindings/core/v8/CustomElementConstructorBuilder.cpp:204: if
> (!m_prototype->Get(context, constructorKey).ToLocal(&constructorPrototype))
> > Now, we are using maybe version of *Get*.
> 
> Thats great. Will it be possible for us to add even a layout test based on the
> minimum test case from the fuzzer to validate this? [1]
> 
> [1]
>
https://cluster-fuzz.appspot.com/viewer?blob_key=AMIfv96kq7dCUbMoIAtn-NLi9psH...

I have added the test case specified here :
https://code.google.com/p/chromium/issues/detail?id=478329#c4
That test case is "exception-from-constructor.html".

Actually, I can't see that cluster-fuzz link. So, if that is another test case,
please provide the test case content.
Thanks!

[vivekg, 2015-04-21 09:42:49]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-04-21 09:42:50]

https://codereview.chromium.org/1097243002/diff/1/LayoutTests/fast/dom/custom...
File LayoutTests/fast/dom/custom/exception-from-constructor.html (right):

https://codereview.chromium.org/1097243002/diff/1/LayoutTests/fast/dom/custom...
LayoutTests/fast/dom/custom/exception-from-constructor.html:8:
description('Tests throwing an exception during registeration of'
nit: registeration => registration. Also this could be a single line statement
itself.

https://codereview.chromium.org/1097243002/diff/1/LayoutTests/fast/dom/custom...
LayoutTests/fast/dom/custom/exception-from-constructor.html:21: var element =
document.registerElement('x-a', {prototype: proto});
Can we use shouldThrow('document.registerElement(...)') here?

[deepak.s, 2015-04-21 10:08:19]

On 2015/04/21 09:42:50, vivekg_ wrote:
>
https://codereview.chromium.org/1097243002/diff/1/LayoutTests/fast/dom/custom...
> File LayoutTests/fast/dom/custom/exception-from-constructor.html (right):
> 
>
https://codereview.chromium.org/1097243002/diff/1/LayoutTests/fast/dom/custom...
> LayoutTests/fast/dom/custom/exception-from-constructor.html:8:
> description('Tests throwing an exception during registeration of'
> nit: registeration => registration. Also this could be a single line statement
> itself.

Done!

> 
>
https://codereview.chromium.org/1097243002/diff/1/LayoutTests/fast/dom/custom...
> LayoutTests/fast/dom/custom/exception-from-constructor.html:21: var element =
> document.registerElement('x-a', {prototype: proto});
> Can we use shouldThrow('document.registerElement(...)') here?

Done!

[vivekg, 2015-04-21 10:23:44]

LGTM, but lets wait for dominicc@ to rubber-stamp this. Thanks!

[deepak.s, 2015-04-21 10:25:55]

dominicc@ Is it good to go?

[dominicc (has gone to gerrit), 2015-04-23 07:16:22]

lgtm

LGTM modulo one nit with test formatting.

https://codereview.chromium.org/1097243002/diff/60001/LayoutTests/fast/dom/cu...
File
LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval.html
(right):

https://codereview.chromium.org/1097243002/diff/60001/LayoutTests/fast/dom/cu...
LayoutTests/fast/dom/custom/registration-context-delete-during-register-base-constructor-retrieval.html:9:
' point when the prototype\'s constructor property is retrieved.');
This should be indented, probably to line up with the ' on the previous line.

[deepak.s, 2015-04-23 08:27:01]

The CQ bit was checked by deepak.s@samsung.com

[deepak.s, 2015-04-23 08:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, vivekg@chromium.org, dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/1097243002/#ps80001
(title: "Nits")

[commit-bot: I haz the power, 2015-04-23 08:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097243002/80001

[commit-bot: I haz the power, 2015-04-23 13:54:24]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194296