LayoutTests/fast/dom/custom/exception-from-constructor.html - Issue 1097243002: [Reland] Implement Custom Element's class side inheritance

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/exception-from-constructor.html

Issue 1097243002: [Reland] Implement Custom Element's class side inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/custom/class-side-inheritance.html ('k') | LayoutTests/fast/dom/custom/exception-from-constructor-expected.txt » ('j') | Source/bindings/core/v8/CustomElementConstructorBuilder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <script src="testutils.js"></script>	3 <script src="testutils.js"></script>

4 <body>	4 <body>

5 <script>	5 <script>

6 if (fork()) {	6 if (fork()) {

7 // The controlling parent frame	7 // The controlling parent frame

8 description('Tests destroying a context during registration at the point whe n the created callback is retrieved.');	8 description('Tests throwing an exception during registeration of'
	vivekg 2015/04/21 09:42:49 nit: registeration => registration. Also this coul nit: registeration => registration. Also this could be a single line statement itself.
	9 + 'constructor');

9 jsTestIsAsync = true;	10 jsTestIsAsync = true;

10 successfullyParsed = true;	11 successfullyParsed = true;

11 } else {	12 } else {

12 // The child frame

13

14 var proto = Object.create(HTMLElement.prototype, {	13 var proto = Object.create(HTMLElement.prototype, {

15 createdCallback: {	14 constructor: {

16 get: function () {	15 configurable: true,

17 destroyContext();	16 get: function () { throw "Exception thrown from getter"; }

18 return function () { }

19 }	17 }

20 }	18 });

21 });

22	19

23 try {	20 try {

24 document.registerElement('x-a', {prototype: proto});	21 var element = document.registerElement('x-a', {prototype: proto});
	vivekg 2015/04/21 09:42:49 Can we use shouldThrow('document.registerElement(. Can we use shouldThrow('document.registerElement(...)') here?
25 log('FAIL expected register to throw an exception');	22 log('FAIL expected register to throw an exception');

26 } catch (ex) {	23 } catch (ex) {

27 log('PASS caught expected exception "' + ex + '"');	24 log('PASS caught expected exception "' + ex + '"');

28 }	25 }

29 done();	26 done();

30 }	27 }

31 </script>	28 </script>

OLD	NEW