Issue 10970026: Fix drive-by memory leak in media_galleries_api.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10970026: Fix drive-by memory leak in media_galleries_api.cc. (Closed)

Created:
8 years, 3 months ago by not at google - send to devlin

Modified:
8 years, 3 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix drive-by memory leak in media_galleries_api.cc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158223

Patch Set 2 : include scoped_ptr #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/extensions/api/media_galleries/media_galleries_api.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

https://codereview.chromium.org/10970026/diff/1/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc (right): https://codereview.chromium.org/10970026/diff/1/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc#newcode128 chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:128: continue; leak here

8 years, 3 months ago (2012-09-21 01:08:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10970026/3001

8 years, 3 months ago (2012-09-23 23:41:43 UTC) #3

Change committed as 158223

Expand Messages | Collapse Messages

Issue 10970026: Fix drive-by memory leak in media_galleries_api.cc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : include scoped_ptr #

Messages