Fix drive-by memory leak in media_galleries_api.cc.

chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Media Galleries API.
 
 #include "chrome/browser/extensions/api/media_galleries/media_galleries_api.h"
 
 #include <set>
 #include <string>
@@ skipping 96 matching lines @@
       render_view_host(), GetExtension(), base::Bind(
           &MediaGalleriesGetMediaFileSystemsFunction::ReturnGalleries, this));
 }
 
 void MediaGalleriesGetMediaFileSystemsFunction::ReturnGalleries(
     const std::vector<MediaFileSystemInfo>& filesystems) {
   const int child_id = render_view_host()->GetProcess()->GetID();
   std::set<std::string> file_system_names;
   base::ListValue* list = new base::ListValue();
   for (size_t i = 0; i < filesystems.size(); i++) {
-    base::DictionaryValue* file_system_dict_value = new base::DictionaryValue();
+    scoped_ptr<base::DictionaryValue> file_system_dict_value(
+        new base::DictionaryValue());
 
     // Send the file system id so the renderer can create a valid FileSystem
     // object.
     file_system_dict_value->SetWithoutPathExpansion(
         "fsid", Value::CreateStringValue(filesystems[i].fsid));
 
     // The name must be unique according to the HTML5 File System API spec.
     if (ContainsKey(file_system_names, filesystems[i].name)) {
       NOTREACHED() << "Duplicate file system name: " << filesystems[i].name;
       continue;

[not at google - send to devlin, 2012/09/21 01:08:33]

leak here

     }
     file_system_names.insert(filesystems[i].name);
     file_system_dict_value->SetWithoutPathExpansion(
         "name", Value::CreateStringValue(filesystems[i].name));
 
-    list->Append(file_system_dict_value);
+    list->Append(file_system_dict_value.release());
 
     if (!filesystems[i].path.empty() &&
         MediaGalleriesPermission::HasReadAccess(*GetExtension())) {
       content::ChildProcessSecurityPolicy* policy =
           ChildProcessSecurityPolicy::GetInstance();
       if (!policy->CanReadFile(child_id, filesystems[i].path))
         policy->GrantReadFile(child_id, filesystems[i].path);
       policy->GrantReadFileSystem(child_id, filesystems[i].fsid);
     }
     // TODO(vandebo) Handle write permission.
@@ skipping 33 matching lines @@
 bool MediaGalleriesAssembleMediaFileFunction::RunImpl() {
   if (!ApiIsAccessible(&error_))
     return false;
 
   // TODO(vandebo) Update the metadata and return the new file.
   SetResult(Value::CreateNullValue());
   return true;
 }
 
 }  // namespace extensions