Update resource_bundle.h image function comment.

Update resource_bundle.h image function comment.

Based on the guidance in this chromium-dev thread:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/IXPJs131xCc/discussion

BUG=none
R=sail@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157927

[msw, 2012-09-20 17:35:27]

Hey Sail, please take a look; Rober/Peter correct me if I'm wrong; thanks!

[Robert Sesek, 2012-09-20 17:37:34]

https://codereview.chromium.org/10970018/diff/1/ui/base/resource/resource_bun...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/10970018/diff/1/ui/base/resource/resource_bun...
ui/base/resource/resource_bundle.h:180: // NOTE: GetImageNamed is preferred for
cross-platform gfx::Image use,
GetNativeImageNamed, per below.

[sail, 2012-09-20 17:40:04]

https://codereview.chromium.org/10970018/diff/1/ui/base/resource/resource_bun...
File ui/base/resource/resource_bundle.h (right):

https://codereview.chromium.org/10970018/diff/1/ui/base/resource/resource_bun...
ui/base/resource/resource_bundle.h:180: // NOTE: GetImageNamed is preferred for
cross-platform gfx::Image use,
I don't think this comment is correct.

Unless you're doing WebUI or there's some exceptional reason, you should be
using gfx::Image. This means Views code should be using gfx::Image.

At least, that's what I got out of this comment:

> The rule of thumb is: if the image goes through cross-platform code and is
eventually going to be drawn in platform-specific code, it should be in a
gfx::Image. If it's for WebUI, only exists in views code, or is part of some
Skia-based compositing operation, use gfx::ImageSkia.

[msw, 2012-09-20 18:03:30]

Okay, updated. Sail explained that it's counter-productive to call out Views as
an exception (despite convenience), since the long term goal is to use
gfx::Image everywhere.

[sail, 2012-09-20 18:07:52]

LGTM!

[commit-bot: I haz the power, 2012-09-20 18:11:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10970018/5001

[commit-bot: I haz the power, 2012-09-21 01:34:56]

Retried try job too often for step(s) browser_tests

[msw, 2012-09-21 01:53:08]

On 2012/09/21 01:34:56, I haz the power (commit-bot) wrote:
> Retried try job too often for step(s) browser_tests

stupid CQ, it's a comment... landing manually.

[msw, 2012-09-21 01:55:33]

On 2012/09/21 01:53:08, msw wrote:
> On 2012/09/21 01:34:56, I haz the power (commit-bot) wrote:
> > Retried try job too often for step(s) browser_tests
> 
> stupid CQ, it's a comment... landing manually.

Gah, tree's closed and I need to unplug my machine to move...

[commit-bot: I haz the power, 2012-09-21 01:55:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10970018/5001

[commit-bot: I haz the power, 2012-09-21 04:50:05]

Change committed as 157927