Extended sanity checks in WASAPIAudioOutputStream

This CL is an attempt to improve sanity in WASAPIAudioOutputStream where we today see odd crashes related to an illegal AudioSourceCallback pointer.

BUG=150619
TEST=media_unittests and content_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157756

[henrika (OOO until Aug 14), 2012-09-20 11:53:55]

Tommi, please take a look.

[tommi (sloooow) - chröme, 2012-09-20 12:15:38]

lgtm with the below fixed.

https://codereview.chromium.org/10970010/diff/1/media/audio/win/audio_low_lat...
File media/audio/win/audio_low_latency_output_win.cc (right):

https://codereview.chromium.org/10970010/diff/1/media/audio/win/audio_low_lat...
media/audio/win/audio_low_latency_output_win.cc:985: CHECK(started() &&
(GetCurrentThreadId() == render_thread_->tid() ||
I see you've changed the parenthesis, but the check is incorrect now.
This should be:

(started() && GetCurrentThreadId()) == render_thread_->tid()) ||
GetCurrentThreadId() == creating_thread_id_

You should also add a second !started() check to be absolutely sure:

(started() && GetCurrentThreadId()) == render_thread_->tid()) ||
(!started() && GetCurrentThreadId() == creating_thread_id_)

[henrika (OOO until Aug 14), 2012-09-20 12:27:19]

Thanks.

Now what?

https://codereview.chromium.org/10970010/diff/1/media/audio/win/audio_low_lat...
File media/audio/win/audio_low_latency_output_win.cc (right):

https://codereview.chromium.org/10970010/diff/1/media/audio/win/audio_low_lat...
media/audio/win/audio_low_latency_output_win.cc:985: CHECK(started() &&
(GetCurrentThreadId() == render_thread_->tid() ||
On 2012/09/20 12:15:38, tommi wrote:
> I see you've changed the parenthesis, but the check is incorrect now.
> This should be:
> 
> (started() && GetCurrentThreadId()) == render_thread_->tid()) ||
> GetCurrentThreadId() == creating_thread_id_
> 
> You should also add a second !started() check to be absolutely sure:
> 
> (started() && GetCurrentThreadId()) == render_thread_->tid()) ||
> (!started() && GetCurrentThreadId() == creating_thread_id_)

Done.

[commit-bot: I haz the power, 2012-09-20 12:46:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/10970010/1003