Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1720)

Unified Diff: apps/saved_files_service.h

Issue 1096983002: Update usages of std::map to use ScopedPtrMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@passwordmanager-scopedmemory
Patch Set: Fix Mac compile. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | apps/saved_files_service.cc » ('j') | apps/saved_files_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/saved_files_service.h
diff --git a/apps/saved_files_service.h b/apps/saved_files_service.h
index de1b1a26b9991dd58466bd652c8da44b4fec4de4..ec1671ef43aed1a796387faaa8473e499afd9782 100644
--- a/apps/saved_files_service.h
+++ b/apps/saved_files_service.h
@@ -5,14 +5,14 @@
#ifndef APPS_SAVED_FILES_SERVICE_H_
#define APPS_SAVED_FILES_SERVICE_H_
-#include <map>
#include <set>
#include <string>
#include <vector>
+#include "base/containers/scoped_ptr_map.h"
#include "base/files/file_path.h"
#include "base/gtest_prod_util.h"
-#include "base/stl_util.h"
+#include "base/memory/scoped_ptr.h"
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -127,9 +127,8 @@ class SavedFilesService : public KeyedService,
static void SetLruSizeForTest(int size);
static void ClearLruSizeForTest();
- std::map<std::string, SavedFiles*> extension_id_to_saved_files_;
- STLValueDeleter<std::map<std::string, SavedFiles*> >
- extension_id_to_saved_files_deleter_;
+ ScopedPtrMap<std::string, scoped_ptr<SavedFiles>>
tapted 2015/06/19 00:12:01 should ScopedPtrMap be in namespace base::, same a
Matt Giuca 2015/06/19 04:03:25 I've asked Dana this on http://crbug.com/502128. I
Matt Giuca 2015/06/22 05:40:41 Done in precursor CL https://codereview.chromium.o
+ extension_id_to_saved_files_;
content::NotificationRegistrar registrar_;
Profile* profile_;
« no previous file with comments | « no previous file | apps/saved_files_service.cc » ('j') | apps/saved_files_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698