Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1194373002: Moved ScopedPtrMap into base namespace. (Closed)

Created:
5 years, 6 months ago by Matt Giuca
Modified:
5 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jianli-gcm_client_impl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved ScopedPtrMap into base namespace. BUG=502128 TBR=reillyg@chromium.org Committed: https://crrev.com/d6af321321aefb7c3fdca9b2acdbd638b51de9a7 Cr-Commit-Position: refs/heads/master@{#335895}

Patch Set 1 #

Patch Set 2 : Rebase and update against media_galleries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M base/containers/scoped_ptr_map.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/containers/scoped_ptr_map_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/gallery_watch_manager.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
Matt Giuca
danakj@chromium.org: Please review changes in base/containers/scoped_ptr_map*. rtenneti@chromium.org: TBR for mechanical change in c/b/metrics.
5 years, 6 months ago (2015-06-22 05:25:50 UTC) #2
ramant (doing other things)
LGTM for metrics code.
5 years, 6 months ago (2015-06-22 17:44:55 UTC) #3
danakj
LGTM
5 years, 6 months ago (2015-06-22 17:45:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194373002/1
5 years, 6 months ago (2015-06-23 03:26:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/66349)
5 years, 6 months ago (2015-06-23 03:39:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194373002/1
5 years, 6 months ago (2015-06-23 04:19:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/66369)
5 years, 6 months ago (2015-06-23 04:35:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194373002/1
5 years, 6 months ago (2015-06-23 20:48:41 UTC) #16
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 20:57:52 UTC) #18
Matt Giuca
reillyg: TBR for media galleries.
5 years, 6 months ago (2015-06-24 08:14:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194373002/20001
5 years, 6 months ago (2015-06-24 08:14:38 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 09:45:52 UTC) #24
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 09:46:55 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6af321321aefb7c3fdca9b2acdbd638b51de9a7
Cr-Commit-Position: refs/heads/master@{#335895}

Powered by Google App Engine
This is Rietveld 408576698