Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1096963002: Make UseCounters work on aliased properties (Closed)

Created:
5 years, 8 months ago by Timothy Loh
Modified:
5 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, Steve Block, Timothy Loh, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make UseCounters work on aliased properties This patch starts to build a coherent system for aliased properties. The general plan is for property aliases to get resolved as early as possible. Properties with no differences or minor differences in parsing will use this code-path, while properties with larger differences will still require aliases to leak into the rest of the system. Property aliases are generally resolved during parsing (although for will-change and transition-property we leave aliases in), so that we only store resolved properties on StylePropertySets. Property aliases which parse slightly differently will parse into CSSValues which are also valid for the aliased properties. The handling here is similar to shorthands, where we don't have the type safety of a separate enum, but functions that don't take aliases will simply assume that they aren't given aliases. This is as there is no nice way to do enum inheritance in C++. Eventually most aliases will use the new system. For now, we only move across properties which are already marked as alias_for, making the UseCounters work for these. BUG=277126, 410112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194021

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -81 lines) Patch
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 5 chunks +7 lines, -6 lines 0 comments Download
M Source/build/scripts/css_properties.py View 1 2 3 3 chunks +18 lines, -3 lines 0 comments Download
M Source/build/scripts/make_css_property_names.py View 3 chunks +15 lines, -8 lines 0 comments Download
M Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSTransitionData.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSParser.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 1 chunk +10 lines, -9 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 1 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/parser/CSSParserToken.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserToken.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 9 chunks +24 lines, -15 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 6 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Timothy Loh
5 years, 8 months ago (2015-04-20 01:05:01 UTC) #2
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/1096963002/diff/40001/Source/build/scripts/css_properties.py File Source/build/scripts/css_properties.py (right): https://codereview.chromium.org/1096963002/diff/40001/Source/build/scripts/css_properties.py#newcode55 Source/build/scripts/css_properties.py:55: # StylePropertyMetadata also assumes there are under 1024 ...
5 years, 8 months ago (2015-04-20 06:19:37 UTC) #3
Timothy Loh
+haraken for Source/bindings OWNERS https://codereview.chromium.org/1096963002/diff/40001/Source/build/scripts/css_properties.py File Source/build/scripts/css_properties.py (right): https://codereview.chromium.org/1096963002/diff/40001/Source/build/scripts/css_properties.py#newcode55 Source/build/scripts/css_properties.py:55: # StylePropertyMetadata also assumes there ...
5 years, 8 months ago (2015-04-20 07:14:30 UTC) #5
haraken
bindings/ LGTM
5 years, 8 months ago (2015-04-20 07:20:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096963002/60001
5 years, 8 months ago (2015-04-20 07:21:43 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 12:03:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194021

Powered by Google App Engine
This is Rietveld 408576698