Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: Source/core/css/CSSProperties.in

Issue 1096963002: Make UseCounters work on aliased properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/css/CSSTransitionData.h ('k') | Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSProperties.in
diff --git a/Source/core/css/CSSProperties.in b/Source/core/css/CSSProperties.in
index 810c1a62c66e43aac8ac7bf620236d9f3280331c..b4c3887cca810b792f844e9f31f218dd8decad40 100644
--- a/Source/core/css/CSSProperties.in
+++ b/Source/core/css/CSSProperties.in
@@ -4,13 +4,14 @@
// - alias_for=other-property
-// Properties specifying alias_for do not get their own enum and instead map
-// directly onto the CSSPropertyID they alias. Currently this means that the
-// UseCounter will not pick up on these (crbug.com/304855)
+// Properties specifying alias_for should be virtually identical to the
+// properties they alias. Minor parsing differences are allowed as long as
+// the CSSValues created are of the same format of the aliased property.
// - runtime_flag=CSSGridLayout
-// The flag on RuntimeEnabledFeatures conditionally enables the property
+// The flag on RuntimeEnabledFeatures conditionally enables the property.
+// This doesn't currently work with alias_for.
// - longhands=property;other-property
« no previous file with comments | « Source/core/animation/css/CSSTransitionData.h ('k') | Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698