Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 10969061: Split test/mjsunit/debug-stepout-scope into smaller chunks (Closed)

Created:
6 years, 12 months ago by Jakob Kummerow
Modified:
6 years, 12 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Split test/mjsunit/debug-stepout-scope into smaller chunks Committed: https://code.google.com/p/v8/source/detail?r=12596

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -810 lines) Patch
D test/mjsunit/debug-stepout-scope.js View 1 chunk +0 lines, -423 lines 0 comments Download
A test/mjsunit/debug-stepout-scope-part1.js View 1 chunk +190 lines, -0 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part2.js View 1 chunk +46 lines, -33 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part3.js View 1 chunk +43 lines, -33 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part4.js View 1 1 chunk +43 lines, -33 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part5.js View 1 chunk +40 lines, -33 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part6.js View 1 chunk +42 lines, -33 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part7.js View 1 chunk +42 lines, -33 lines 0 comments Download
A + test/mjsunit/debug-stepout-scope-part8.js View 2 chunks +0 lines, -189 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Please take a look. No lines were actually added or removed, just shuffled around; but ...
6 years, 12 months ago (2012-09-24 09:01:43 UTC) #1
Yang
On 2012/09/24 09:01:43, Jakob wrote: > Please take a look. > > No lines were ...
6 years, 12 months ago (2012-09-24 11:14:24 UTC) #2
Yang
With nits btw. http://codereview.chromium.org/10969061/diff/1/test/mjsunit/debug-stepout-scope-part4.js File test/mjsunit/debug-stepout-scope-part4.js (right): http://codereview.chromium.org/10969061/diff/1/test/mjsunit/debug-stepout-scope-part4.js#newcode57 test/mjsunit/debug-stepout-scope-part4.js:57: "if (false) { try { throw ...
6 years, 12 months ago (2012-09-24 11:14:40 UTC) #3
Jakob Kummerow
6 years, 12 months ago (2012-09-24 11:18:34 UTC) #4
http://codereview.chromium.org/10969061/diff/1/test/mjsunit/debug-stepout-sco...
File test/mjsunit/debug-stepout-scope-part4.js (right):

http://codereview.chromium.org/10969061/diff/1/test/mjsunit/debug-stepout-sco...
test/mjsunit/debug-stepout-scope-part4.js:57: "if (false) { try { throw 0; }
catch(x) { return x; } }; debugger; " ];
On 2012/09/24 11:14:40, Yang wrote:
> ditto.

Done.

http://codereview.chromium.org/10969061/diff/1/test/mjsunit/debug-stepout-sco...
File test/mjsunit/debug-stepout-scope.js (left):

http://codereview.chromium.org/10969061/diff/1/test/mjsunit/debug-stepout-sco...
test/mjsunit/debug-stepout-scope.js:138: "if (false) { try { throw 0; } catch(x)
{ return x; } }; debugger; " ];
On 2012/09/24 11:14:40, Yang wrote:
> Keeping the 80-char limit would be nice.

Can't fix it here, this is deleted code ;-)

Powered by Google App Engine
This is Rietveld 408576698