web intents. Fix callbacks to restore tab management on service exit.

chrome/browser/ui/intents/web_intent_picker_controller.h

Index: chrome/browser/ui/intents/web_intent_picker_controller.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.h b/chrome/browser/ui/intents/web_intent_picker_controller.h
index d5b5d614c23d715372b0d8d785868dd9847e180c..54b2156c56e5012efbf8f466ed6051e0a2ed2d2c 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.h
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.h
@@ -311,6 +311,10 @@ class WebIntentPickerController
   // Timer factory for minimum display time of "waiting" dialog.
   base::WeakPtrFactory<WebIntentPickerController> timer_factory_;
 
+  // Weak pointers for the dispatcher OnSendReturnMessage will not be
+  // cancelled on picker close.
+  base::WeakPtrFactory<WebIntentPickerController> dispatcher_factory_;

[please use gerrit instead, 2012/09/20 16:38:30]

What's the different between weak_ptr_factory_ and dispatcher_factory_? (They
are the same type.) Let's add that information to the comments.

[Greg Billock, 2012/09/20 16:45:19]

Done.

+
   // Bucket identifier for UMA reporting. Saved off in a field
   // to avoid repeated calculation of the bucket across
   // multiple UMA calls. Should be recalculated each time